Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach generated request-id to request headers #28

Closed
wants to merge 0 commits into from
Closed

Attach generated request-id to request headers #28

wants to merge 0 commits into from

Conversation

pscheid92
Copy link
Contributor

See Issue #27.

@appleboy
Copy link
Member

appleboy commented Oct 8, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #28 (6a97060) into master (1a81880) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   94.28%   94.44%   +0.15%     
==========================================
  Files           2        2              
  Lines          35       36       +1     
==========================================
+ Hits           33       34       +1     
  Misses          2        2              
Flag Coverage Δ
go- 94.44% <100.00%> (+0.15%) ⬆️
go-1.14 94.44% <100.00%> (+0.15%) ⬆️
go-1.15 94.44% <100.00%> (+0.15%) ⬆️
go-1.16 94.44% <100.00%> (+0.15%) ⬆️
go-1.17 94.44% <100.00%> (+0.15%) ⬆️
go-1.18 94.44% <100.00%> (+0.15%) ⬆️
go-1.19 94.44% <100.00%> (+0.15%) ⬆️
macos-latest 94.44% <100.00%> (+0.15%) ⬆️
ubuntu-latest 94.44% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
requestid.go 91.66% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pscheid92 pscheid92 closed this Oct 8, 2022
@pscheid92
Copy link
Contributor Author

pscheid92 commented Oct 8, 2022

@appleboy I created a new PR here #30

I somehow accidentally broke my fork and closed this PR (also accidentally) while I tried to fix it. 🙈

Today I Learned
Never open a pull request from masterto master. Always use a feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants