Support option for headerXRequestID #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuntagami
changed the title
shuntagami
commented
Apr 17, 2022
| if rid == "" { | ||
| rid = cfg.generator() | ||
| // Set the id to ensure that the requestid is in the request | ||
| c.Request.Header.Add(headerXRequestID, rid) |
There was a problem hiding this comment.
duplicating line 41, so deleted.
|
@appleboy Review plz. |
appleboy
approved these changes
Apr 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 91.66% 92.85% +1.19%
==========================================
Files 2 2
Lines 24 28 +4
==========================================
+ Hits 22 26 +4
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SSIA
Why
Adding option for declaring header key is helpful. For example, in the case we want to call other micro services from gin framework and propagate request id to the services.