Fix bug: the result will be incorrect when call gin.Context.Writer.Status() in our custom gin middleware used after this middleware

[zhyee]

consider this code:

func Timeout() gin.HandlerFunc {
	return timeout.New(timeout.WithTimeout(time.Second*1),
		timeout.WithHandler(func(ctx *gin.Context) {
			ctx.Next()
		}),
		timeout.WithResponse(func(ctx *gin.Context) {
			ctx.String(http.StatusRequestTimeout, "timeout")
		}),
	)
}

func Logger() gin.HandlerFunc {
	return func(c *gin.Context) {
		c.Next()
		// access the status we are sending
		status := c.Writer.Status() // Bug: in any middleware used after this middleware, the result will always be 200.
		log.Println(status)
	}
}

func main() {
	r := gin.New()
	r.Use(Timeout())
	r.Use(Logger())

	r.GET("/test", func(c *gin.Context) {
		c.Status(http.StatusInternalServerError)
	})
	// Listen and serve on 0.0.0.0:8080
	r.Run(":8080")
}

[zhyee]

issue: #47

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e7c3a7b) 94.91% compared to head (fe2c126) 92.91%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
writer.go	40.00%	2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   94.91%   92.91%   -2.01%     
==========================================
  Files           4        4              
  Lines         118      127       +9     
==========================================
+ Hits          112      118       +6     
- Misses          4        6       +2     
- Partials        2        3       +1     

Flag	Coverage Δ
go-	?
go-1.18	?
go-1.19	92.91% <70.00%> (+3.08%)	⬆️
go-1.20	?
go-1.21	?
macos-latest	?
ubuntu-latest	92.91% <70.00%> (-2.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bramsvs]

@zhyee @appleboy any chance this can be reviewed & merged? :)

[millotp]

Hey, this would solve a bug for us too, can we get an update on this ?

[zhyee]

@appleboy Hi, I added a unit test to cover this bug fix, hope to be reviewed.

[appleboy]

can't pass the testing @zhyee

[appleboy]

I created the PR #61