fix: fix rewrite status code warning #51
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gin warning:
reproduced by following code:
The reason is
AbortWithStatus
will firstly callWriteHeader
and then callWriteHeaderNow
for double check (confirm the header already be written and the http status code is not modified).In the master branch,
WriteHeader
implemented bytimeout
repo, butWriteHeaderNow
implemented bygin
repo. And this cause the double write for http status code and the failure.