-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetCookie broken #2214
Comments
Oof |
appleboy
pushed a commit
that referenced
this issue
Jan 22, 2020
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this issue
Feb 19, 2020
when i go get the 1.5.0 version, i can't get newest code with samesite option in SetCookie funciton |
byebyebruce
pushed a commit
to byebyebruce/gin
that referenced
this issue
Mar 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello
It seems you have made a breaking change 4 hours ago (our CI broke)
In source file, SetCookie expects 8 parameters
https://github.com/gin-gonic/gin/blob/master/context.go#L778
In the README, SetCookie expects 7 parameters
https://github.com/gin-gonic/gin/blob/master/README.md
On the CI
Could you please update the README so that it is consistent with the source code? Otherwise, it is hard to find out where the problem comes from, and which one is the good prototype :-)
From commit f94406a
Best
The text was updated successfully, but these errors were encountered: