List the handlers on startup

[jithinjk]

Fairly new to this community. Not sure if this counts as a feature.

• List route handlers at startup,
• Also, number of handlers running.

Would be nice to have this to get better understanding of handlers running.

Sorry for multiple commit builds, new to travis-ci.

[codecov]

Codecov Report

Merging #1131 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage    98.4%   98.42%   +0.02%     
==========================================
  Files          34       34              
  Lines        1757     1781      +24     
==========================================
+ Hits         1729     1753      +24     
  Misses         23       23              
  Partials        5        5

Impacted Files	Coverage Δ
debug.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783c7ee...a076bf3. Read the comment docs.

[thinkerou]

Maybe you should squash commits.

[thinkerou]

use govendor in Makefile?

[jithinjk]

will fix these issues

[jithinjk]

I've updated the Makefile. Can you pls validate now.

[appleboy]

@jithinjk Can you post the screenshots?

[jithinjk]

Attached screenshot. Capture

[thinkerou]

#1729 has added HandlerNames() method, the pr have any worth? thanks! I think we should close the pr, thanks!

[appleboy]

conflicts.

[thinkerou]

@appleboy we still need the pull request? I think we should not use it, because it will depend on one package, the pull request have not clear useful, and we have had HandlerNames method. thanks!

[appleboy]

this should be pending now?

[thinkerou]

closing

[hyson007]

hi,

I couldn't find anywhere mention about this, I'm new to Gin and couldn't figure out why go-gin think there are 3 handlers when I only have one function passed into the POST func?

[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.

[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.
 - using env:   export GIN_MODE=release
 - using code:  gin.SetMode(gin.ReleaseMode)

[GIN-debug] POST /accounts  --> github.com/hyson007/simpleBank/api.(*Server).createAccount-fm (3 handlers) 
^^^^ in above line ^^^^



func NewServer(store *db.Store) *Server {
	server := &Server{store: store}
	router := gin.Default()
	server.router = router

	router.POST("/accounts", server.createAccount)

	return server
}

func (s *Server) Start(addr string) error {
	return s.router.Run(addr)
}

func (s *Server) createAccount(ctx *gin.Context) {
	var req createAccountRequest
	if err := ctx.ShouldBindJSON(&req); err != nil {
		ctx.JSON(http.StatusBadRequest, errorResponse(err))
		return
	}

	arg := db.CreateAccountParams{
		Owner:    req.Owner,
		Currency: req.Currency,
		Balance:  0,
	}

	account, err := s.store.CreateAccount(ctx, arg)
	if err != nil {
		ctx.JSON(http.StatusInternalServerError, errorResponse(err))
		return
	}

	ctx.JSON(http.StatusOK, account)
}