-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml binding #1618
Yaml binding #1618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 99.27% 99.28% +<.01%
==========================================
Files 39 40 +1
Lines 1931 1948 +17
==========================================
+ Hits 1917 1934 +17
Misses 10 10
Partials 4 4
Continue to review full report at Codecov.
|
I'll take a look at improving the test coverage in the next day or so. |
@appleboy please update review comment and then LGTM, thanks! |
@thinkerou Sorry. The external package has already in go.mod. |
@appleboy yes, no sweat. |
This adds binding support for YAML.
Sidenote:
testBodyBinding
usesJSON.Bind
instead of theBinding
instance passed as a parameter when testing thebadBody
. Is this intended?