-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recovery: fix issue about syscall import on google app engine #1640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 40 40
Lines 1973 1973
=======================================
Hits 1959 1959
Misses 10 10
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reviewing before you added the Lower, and was about to make that same suggestion since I saw mixed case between different OS/arch. Good call!
Can it be merged? |
thanks! |
Thank you! |
cc @justinfx please help me review, thanks!
ref: https://github.com/golang/go/blob/master/src/syscall/zerrors_linux_amd64.go