make context.Keys available as LogFormatterParams

[MusicAdam]

This makes the context available in LogFormatterParams and therefore allows access to context variables as part of the log output formatting.

[codecov]

Codecov Report

Merging #1779 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1779      +/-   ##
==========================================
+ Coverage   98.62%   98.62%   +<.01%     
==========================================
  Files          41       41              
  Lines        2112     2113       +1     
==========================================
+ Hits         2083     2084       +1     
  Misses         18       18              
  Partials       11       11

Impacted Files	Coverage Δ
logger.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057f63b...79a0760. Read the comment docs.

[thinkerou]

@MusicAdam why need it? can you post one usage scenario? thanks!

[thinkerou]

closing, thanks!

[MusicAdam]

@thinkerou Its useful for logging context variables, such as a request-id. It makes the logger more robust.

[sairoutine]

Instead of LogFormatterParams containing the context, it is better to add the its parameters or value to LogFormatterParams's field directly.

The context in Logger is useful. However, unnecessary methods of context can be used in the Logger. (For example c.Abort(), c.JSON(), c.Next() etc...)

Calling these functions may cause the unexpected bugs.

[MusicAdam]

Instead of LogFormatterParams containing the context, it is better to add the its parameters or value to LogFormatterParams's field directly.

The context in Logger is useful. However, unnecessary methods of context can be used in the Logger. (For example c.Abort(), c.JSON(), c.Next() etc...)

Calling these functions may cause the unexpected bugs.

This is a good point. I have updated so that context.Keys are passed instead. Since the Keys field is exported, I think it is safe to pass it directly instead of something more complicated like a copy or a separate accessor struct to allow Key retrieval.

[sairoutine]

Great!

[thinkerou]

LGTM, thanks!