chore(go): Add support go 1.20 #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3145 3145
=======================================
Hits 3102 3102
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thinkerou
reviewed
Feb 2, 2023
| @@ -31,7 +31,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest] | |||
| go: [1.16, 1.17, 1.18, 1.19] | |||
| go: ['1.16', '1.17', '1.18', '1.19', '1.20'] | |||
There was a problem hiding this comment.
It does not appear to be correctly identified as go1.20 here.
@thinkerou
|
Wait for sonic to support go1.20. |
appleboy
added
enhancement
dependencies
|
It's done, please review. |
appleboy
approved these changes
Feb 12, 2023
|
@thinkerou Please help to review. |
thinkerou
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.