refactor(context): simplify "GetType()" functions #4080
Merged
+50
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaymeKaydex
changed the title
appleboy
changed the title
|
@KaymeKaydex Please rebase the master branch to start the CI build. |
This PR introduces a generic function, getTyped[T any], to simplify value retrieval in the Context struct. It replaces repetitive type assertions in the GetString GetBool etc. methods.
KaymeKaydex
force-pushed
the
refactor/typed-instead-dublicate
branch
from
c23956d
to
24db9b2
Compare
done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
- Coverage 99.21% 98.93% -0.28%
==========================================
Files 42 44 +2
Lines 3182 3387 +205
==========================================
+ Hits 3157 3351 +194
- Misses 17 25 +8
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
appleboy
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a generic function, getTyped[T any], to simplify value retrieval in the Context struct. It replaces repetitive type assertions in the GetString and GetBool methods and adds comments to previously uncommented functions.
Benefits:
Reduces Code Duplication: Centralizes type assertions.
Enhances Readability: Simplifies method implementations and improves documentation.