-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depercated dpcpp by sycl #1397
Open
yhmtsai
wants to merge
8
commits into
develop
Choose a base branch
from
depercated_dpcpp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Depercated dpcpp by sycl #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Terry Cojean <terry.cojean@kit.edu> Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
ginkgo-bot
added
reg:build
This is related to the build system.
reg:testing
This is related to testing.
reg:ci-cd
This is related to the continuous integration system.
reg:documentation
This is related to documentation.
mod:core
This is related to the core module.
mod:cuda
This is related to the CUDA module.
mod:openmp
This is related to the OpenMP module.
reg:example
This is related to the examples.
reg:benchmarking
This is related to benchmarking.
type:solver
This is related to the solvers
type:preconditioner
This is related to the preconditioners
type:matrix-format
This is related to the Matrix formats
mod:hip
This is related to the HIP module.
type:factorization
This is related to the Factorizations
type:reordering
This is related to the matrix(LinOp) reordering
type:multigrid
This is related to multigrid
type:stopping-criteria
This is related to the stopping criteria
mod:dpcpp
This is related to the DPC++ module.
labels
Aug 22, 2023
Error: The following files need to be formatted:
You can find a formatting patch under Artifacts here or run |
yhmtsai
force-pushed
the
icpx_compilation
branch
5 times, most recently
from
October 13, 2023 12:52
26d266c
to
acf7a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:WIP
This PR is a work in progress. Not ready for review.
mod:core
This is related to the core module.
mod:cuda
This is related to the CUDA module.
mod:dpcpp
This is related to the DPC++ module.
mod:hip
This is related to the HIP module.
mod:openmp
This is related to the OpenMP module.
reg:benchmarking
This is related to benchmarking.
reg:build
This is related to the build system.
reg:ci-cd
This is related to the continuous integration system.
reg:documentation
This is related to documentation.
reg:example
This is related to the examples.
reg:testing
This is related to testing.
type:factorization
This is related to the Factorizations
type:matrix-format
This is related to the Matrix formats
type:multigrid
This is related to multigrid
type:preconditioner
This is related to the preconditioners
type:reordering
This is related to the matrix(LinOp) reordering
type:solver
This is related to the solvers
type:stopping-criteria
This is related to the stopping criteria
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace namespace/compile flag
dpcpp
andDpcppExecutor
withsycl
andSyclExecutor
.Also, replace a lot of dpcpp-related variable and name.
For namespace deprecation, it's a little weird.
Although https://en.cppreference.com/w/cpp/language/attributes/deprecated shows the namespace deprecation should be available since c++14, clang will show it from c++17-extension like https://stackoverflow.com/questions/22806878/is-there-a-way-to-deprecate-a-namespace
clang only mentions it as c++17-extension after 6.
I do not find a way to disable c++17-extension for
-std=c++14
to check the behavior without the extension.Currently, I only provide the function or type alias deprecation for those public functions or types.
However, introducing the sycl namespace leads the type/function from sycl standard are not found by
sycl::...
.Thus, it's required to use
::sycl::...
for all of them.Another way is to add
using namespace ::sycl;
in the gko sycl namespace (maybe the include/ginkgo/core/base/executor.hpp is a good place because everything will include it).or use another name for namespace.
TODO:
.dp.cpp/hpp
to.sycl.cpp/hpp
or just normal.cpp/hpp