Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zip_iterator to be used on the device #1604

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Allow zip_iterator to be used on the device #1604

merged 3 commits into from
Jul 11, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented May 1, 2024 •
edited
Loading

This replaces std::tuple by a custom device_tuple implementation to be used on the device.

TODO

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label May 1, 2024
@upsj upsj requested a review from a team May 1, 2024 13:42
@upsj upsj self-assigned this May 1, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. mod:core This is related to the core module. mod:openmp This is related to the OpenMP module. mod:reference This is related to the reference module. type:matrix-format This is related to the Matrix formats type:multigrid This is related to multigrid labels May 1, 2024
@upsj upsj mentioned this pull request May 1, 2024
Merged
2 tasks
@tcojean tcojean added this to the Ginkgo 1.9.0 milestone May 3, 2024
@upsj upsj force-pushed the c++17 branch 4 times, most recently from b59f135 to 1334ea7 Compare July 8, 2024 13:17
Base automatically changed from c++17 to develop July 8, 2024 22:04
fritzgoebel
fritzgoebel approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@fritzgoebel fritzgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am not 100% sure I understand all that's going on with the template <typename... Ts> so definitely someone else should also give their opinion.

@MarcelKoch MarcelKoch self-requested a review July 10, 2024 09:23
MarcelKoch
MarcelKoch approved these changes Jul 10, 2024
View reviewed changes
core/base/iterator_factory.hpp Show resolved Hide resolved
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 10, 2024
@upsj
fixes for MSVC and nvc++
3f5e359 
- MSVC finds the get(...) member function, so we need to call the free function explicitly
- the structured bindings refer to a reference
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Jul 11, 2024
@upsj upsj merged commit ded657c into develop Jul 11, 2024
10 of 14 checks passed
@upsj upsj deleted the device_zip_iterator branch July 11, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzgoebel fritzgoebel fritzgoebel approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. mod:openmp This is related to the OpenMP module. mod:reference This is related to the reference module. reg:build This is related to the build system. reg:testing This is related to testing. type:matrix-format This is related to the Matrix formats type:multigrid This is related to multigrid
Projects
None yet
Milestone
Ginkgo 1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@upsj @MarcelKoch @fritzgoebel @tcojean @ginkgo-bot