Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rocthrust through cmake #1668

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add rocthrust through cmake #1668

merged 1 commit into from
Aug 20, 2024

Conversation

MarcelKoch
Copy link
Member

This PR uses CMake to find and add rocthrust. This fixes the spack issue reported in spack/spack#44923.

@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Aug 16, 2024
@MarcelKoch MarcelKoch requested a review from a team August 16, 2024 10:45
@MarcelKoch MarcelKoch self-assigned this Aug 16, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:hip This is related to the HIP module. labels Aug 16, 2024
@MarcelKoch
Copy link
Member Author

I will wait merging this until spack/spack#45791 is resolved. Maybe there is still something missing.

@yhmtsai
Copy link
Member

yhmtsai commented Aug 16, 2024

question: do you create a patch in spack package? or should we release 1.8.1

@MarcelKoch
Copy link
Member Author

There is a patch for the spack package. I think there is no need for an 1.8.1 otherwise.

@wdconinc wdconinc mentioned this pull request Aug 16, 2024
Merged
@MarcelKoch
Copy link
Member Author

The spack CI passed, so I consider this PR to be complete.

@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 19, 2024
@MarcelKoch MarcelKoch merged commit 369b12a into develop Aug 20, 2024
9 of 14 checks passed
@MarcelKoch MarcelKoch deleted the fix-rocthrust-cmake branch August 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@pratikvn pratikvn pratikvn approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

Assignees

@MarcelKoch MarcelKoch

Labels
1:ST:ready-to-merge This PR is ready to merge. mod:hip This is related to the HIP module. reg:build This is related to the build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcelKoch @yhmtsai @upsj @pratikvn @ginkgo-bot