Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify and simplify batch functionality: Matrix formats (csr, dense, ell) #1669

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Unify and simplify batch functionality: Matrix formats (csr, dense, ell) #1669

merged 9 commits into from
Aug 23, 2024

Conversation

pratikvn
Copy link
Member

@pratikvn pratikvn commented Aug 21, 2024 •
edited
Loading

Part 2 of the refactor: Unify and simplify batch functionality for matrix formats

TODO

  • Reference and omp kernels
  • Dpcpp kernels

@pratikvn pratikvn added type:batched-functionality This is related to the batched functionality in Ginkgo 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Aug 21, 2024
@pratikvn pratikvn requested review from a team August 21, 2024 13:47
@pratikvn pratikvn self-assigned this Aug 21, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. type:solver This is related to the solvers type:matrix-format This is related to the Matrix formats mod:hip This is related to the HIP module. labels Aug 21, 2024
@pratikvn pratikvn added the 1:ST:ready-for-review This PR is ready for review label Aug 22, 2024
upsj
upsj approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't see any functional changes at a cursory glance, are there any, or just renaming and code movement?

common/cuda_hip/base/batch_multi_vector_kernels.hpp Outdated Show resolved Hide resolved
@pratikvn
Copy link
Member Author

Yes, there are no functional changes. Only unification, and a few function name changes.

@MarcelKoch MarcelKoch self-requested a review August 23, 2024 13:06
MarcelKoch
MarcelKoch requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some minor question that I would like to get clarified.

common/cuda_hip/base/types.hpp Outdated Show resolved Hide resolved
common/cuda_hip/solver/batch_bicgstab_kernels.hpp.inc Show resolved Hide resolved
reference/matrix/batch_csr_kernels.cpp Outdated Show resolved Hide resolved
@pratikvn pratikvn added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 23, 2024
@pratikvn pratikvn merged commit 70669c6 into develop Aug 23, 2024
10 of 14 checks passed
@pratikvn pratikvn deleted the batch-unif-2 branch August 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

Assignees

@pratikvn pratikvn

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:build This is related to the build system. type:batched-functionality This is related to the batched functionality in Ginkgo type:matrix-format This is related to the Matrix formats type:solver This is related to the solvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratikvn @upsj @MarcelKoch @ginkgo-bot