-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hip path manipulation #1673
Conversation
dea99db
to
aa35529
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. does it also need to wait for the new image?
That will be great if you add the warning to the ReadME or known issue after it is merged
works fine for me! |
aa35529
to
43a371b
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1673 +/- ##
===========================================
+ Coverage 89.96% 90.24% +0.27%
===========================================
Files 763 763
Lines 62878 62841 -37
===========================================
+ Hits 56571 56713 +142
+ Misses 6307 6128 -179 ☔ View full report in Codecov by Sentry. |
This PR removes the setting of the
HIP_PATH
environment variable. It also removes setting the paths for each rocm library individually. Instead, it is expected that user provide the correctCMAKE_PREFIX_PATH
during configuration.Additionally, a check is introduced to warn about rocm's faulty CMake setup. For rocm 5.0-5.6 the default installation (as provided in the rocm/dev images) has some bugs, which prevent even the simplest CMake setup to enable the HIP language.