Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hip path manipulation #1673

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

MarcelKoch
Copy link
Member

This PR removes the setting of the HIP_PATH environment variable. It also removes setting the paths for each rocm library individually. Instead, it is expected that user provide the correct CMAKE_PREFIX_PATH during configuration.
Additionally, a check is introduced to warn about rocm's faulty CMake setup. For rocm 5.0-5.6 the default installation (as provided in the rocm/dev images) has some bugs, which prevent even the simplest CMake setup to enable the HIP language.

@MarcelKoch MarcelKoch self-assigned this Aug 29, 2024
@ginkgo-bot ginkgo-bot added the reg:build This is related to the build system. label Aug 29, 2024
@MarcelKoch MarcelKoch requested a review from a team August 29, 2024 08:05
@MarcelKoch MarcelKoch linked an issue Aug 29, 2024 that may be closed by this pull request
@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Aug 29, 2024
@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Aug 29, 2024
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. does it also need to wait for the new image?
That will be great if you add the warning to the ReadME or known issue after it is merged

@yhmtsai yhmtsai requested a review from a team August 31, 2024 18:36
@tpadioleau
Copy link

works fine for me!

@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Oct 14, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (eb7ba1c) to head (f6eb48a).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1673      +/-   ##
===========================================
+ Coverage    89.96%   90.24%   +0.27%     
===========================================
  Files          763      763              
  Lines        62878    62841      -37     
===========================================
+ Hits         56571    56713     +142     
+ Misses        6307     6128     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcelKoch MarcelKoch merged commit 8530831 into develop Oct 15, 2024
11 of 14 checks passed
@MarcelKoch MarcelKoch deleted the remove-hip-path-manipulation branch October 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default HIP_PATH does not work with ROCm >= 6.0
5 participants