Fix complex conjugate in MGS dot product #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbeams
added
mod:core
yhmtsai
approved these changes
Sep 11, 2024
MarcelKoch
approved these changes
Sep 12, 2024
MarcelKoch
added
1:ST:ready-to-merge
nbeams
force-pushed
the
gmres-fix-conj
branch
from
0199553
to
aa09fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the discrepancy between MGS and CGS in GMRES convergence for complex numbers, since
compute_conj_dottakes the conjugate of the calling vector, rather than the argument.