-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel ILU factorization with a reference implementation #305
Commits on Jun 6, 2019
-
Added ParIlu factorization factory
- Added stubs for ilu factorization factory, including stubs and reference implementations (which were provided by @hartwiganzt) for 3 kernels. - Added core test for the ParILU Factory.
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0833118 - Browse repository at this point
Copy the full SHA 0833118View commit details -
Made ParIlu inherit from Composition
ParIlu factorization is now inheriting from `Composition` instead from `LinOpFactory` (or similar). Additionally, all added files are now also mentioned inside the appropriate `CMakeLists.txt`.
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 4e185f6 - Browse repository at this point
Copy the full SHA 4e185f6View commit details -
Further work on ParIlu factorization
- Added `get_l` and `get_u_factor` to ParIluFactors - Fixed compiler errors for reference implementation - Added simple test for reference implementation
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for c27a28a - Browse repository at this point
Copy the full SHA c27a28aView commit details -
First complete version of ParIlu
- Renamed class to `ParIlu` (and the files accordingly) - Added `iterations` variable to `ParIlu` to set the number of iterations of the compute kernel - Extended both `core` and `reference` test - optimized conversions (`system_matrix` -> Csr, Coo) by reducing the number of copies
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 67697c0 - Browse repository at this point
Copy the full SHA 67697c0View commit details -
Improved ParIlu tests, corrected kernel
- Added apply test for ParIlu - Made all test matrices const - Added additional reference tests for the 3 kernels - Fixed wrong include file in `common_kernels` - Fixed a mistake in the compute_l_u kernel (still not correct) - Added comments to compute_l_u kernel - Added debug output (MUST BE REMOVED BEFORE MERGING)
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 7a30066 - Browse repository at this point
Copy the full SHA 7a30066View commit details -
Removed existing bug from ParIlu
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for e903059 - Browse repository at this point
Copy the full SHA e903059View commit details -
Finished first complete version of ParIlu
- All debug output was removed - More tests were added (to cover most of the corner cases) - Documentation was extended
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 00c9055 - Browse repository at this point
Copy the full SHA 00c9055View commit details -
Added option to sort Csr Matrices
Sorting of Csr matrices is required for ParIlu to work with any kind of matrix input. Currently, only the reference implementation is done. It is performed with `std::sort` with a custom Iterator. That helps to prevent both unnecessary copies and the need to implement a custom sorting algorithm.
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 6a96b91 - Browse repository at this point
Copy the full SHA 6a96b91View commit details -
Finished adding sorting to CSR matrix
- Moved (and renamed) the former CustomIterator (now IteratorFactory) to a separate file - Added documentation to IteratorFactory - Added tests for IteratorFactory - Added tests for sorting in CSR - Added sorting to ParIlu, so all tests succeed
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for ec6dbb3 - Browse repository at this point
Copy the full SHA ec6dbb3View commit details -
The core test for ParIlu used kernels from the reference module, which are not required to exist for the core tests. All relevant tests were moved to the reference test.
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for afb5269 - Browse repository at this point
Copy the full SHA afb5269View commit details -
Corrected comment shift (caused by make-format)
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for d890a8a - Browse repository at this point
Copy the full SHA d890a8aView commit details -
In ParIlu,
iterations
now have anAuto
valueInstead of having the same default value on all executors, it now defaults to `0`, which means the implementation can freely choose how many iterations are appropriate for the given ressources.
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0300184 - Browse repository at this point
Copy the full SHA 0300184View commit details -
Updated documentation of ParIlu
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0486f1c - Browse repository at this point
Copy the full SHA 0486f1cView commit details -
Improved Documentation and code coverage
- Added used LaTeX packages into `Doxyfile-usr.in` - Improved code coverage by adding tests for + `IteratorFactory` (specifically for the `operator<` in Reference) + `ParIlu` (Added additional test with sorted CSR matrix) - re-added the overview description for `ParIlu`
Thomas Grützmacher committedJun 6, 2019 Configuration menu - View commit details
-
Copy full SHA for e8108e8 - Browse repository at this point
Copy the full SHA e8108e8View commit details
Commits on Jun 13, 2019
-
Added changes from the review comments
Thomas Grützmacher committedJun 13, 2019 Configuration menu - View commit details
-
Copy full SHA for e9e876b - Browse repository at this point
Copy the full SHA e9e876bView commit details -
Thomas Grützmacher committed
Jun 13, 2019 Configuration menu - View commit details
-
Copy full SHA for 637af5a - Browse repository at this point
Copy the full SHA 637af5aView commit details -
Restrict the CI system to only use the 1st GPU
To prevent conflicts with other users on the CI system, we now restrict it to only use the first GPU (device ID 0) for all tests. Note: That also restricts the CUDA executor copy test to a single GPU, meaning data will be copied internally on a single GPU instead of across devices.
Thomas Grützmacher committedJun 13, 2019 Configuration menu - View commit details
-
Copy full SHA for dbabfdb - Browse repository at this point
Copy the full SHA dbabfdbView commit details