NC14.0.1 & metadata 0.7.0: "App is not compliant"

[Sanookmakmak]

occ app:check-code metadata

Analysing /var/www/html/apps/metadata/lib/GetID3/Audio/getid3_dts.php
 4 errors
    line  124: == - is discouraged
    line  125: == - is discouraged
    line  138: == - is discouraged
    line  138: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Audio/getid3_ac3.php
 21 errors
    line  104: == - is discouraged
    line  201: == - is discouraged
    line  216: == - is discouraged
    line  223: == - is discouraged
    line  248: == - is discouraged
    line  253: == - is discouraged
    line  264: == - is discouraged
    line  268: == - is discouraged
    line  270: == - is discouraged
    line  344: == - is discouraged
    line  354: == - is discouraged
    line  372: == - is discouraged
    line  385: == - is discouraged
    line  397: == - is discouraged
    line  397: != - is discouraged
    line  400: == - is discouraged
    line  401: != - is discouraged
    line  578: == - is discouraged
    line  579: == - is discouraged
    line  630: == - is discouraged
    line  690: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Audio/getid3_ogg.php
 29 errors
    line   59: == - is discouraged
    line   65: == - is discouraged
    line   69: == - is discouraged
    line   71: == - is discouraged
    line   75: == - is discouraged
    line  127: == - is discouraged
    line  188: == - is discouraged
    line  221: == - is discouraged
    line  243: == - is discouraged
    line  249: == - is discouraged
    line  258: == - is discouraged
    line  258: != - is discouraged
    line  304: != - is discouraged
    line  328: == - is discouraged
    line  347: == - is discouraged
    line  358: == - is discouraged
    line  363: == - is discouraged
    line  368: == - is discouraged
    line  368: == - is discouraged
    line  400: == - is discouraged
    line  418: == - is discouraged
    line  422: == - is discouraged
    line  425: == - is discouraged
    line  456: == - is discouraged
    line  489: != - is discouraged
    line  551: == - is discouraged
    line  554: == - is discouraged
    line  676: == - is discouraged
    line  687: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Audio/getid3_mp3.php
 89 errors
    line   51: != - is discouraged
    line   62: == - is discouraged
    line   64: == - is discouraged
    line   70: == - is discouraged
    line   93: == - is discouraged
    line  114: == - is discouraged
    line  132: == - is discouraged
    line  181: == - is discouraged
    line  256: == - is discouraged
    line  266: == - is discouraged
    line  282: == - is discouraged
    line  299: == - is discouraged
    line  306: == - is discouraged
    line  349: == - is discouraged
    line  349: != - is discouraged
    line  351: == - is discouraged
    line  351: != - is discouraged
    line  430: != - is discouraged
    line  477: == - is discouraged
    line  494: == - is discouraged
    line  502: == - is discouraged
    line  502: == - is discouraged
    line  509: == - is discouraged
    line  515: == - is discouraged
    line  526: == - is discouraged
    line  526: == - is discouraged
    line  544: != - is discouraged
    line  562: == - is discouraged
    line  604: == - is discouraged
    line  604: == - is discouraged
    line  669: == - is discouraged
    line  693: == - is discouraged
    line  756: == - is discouraged
    line  766: != - is discouraged
    line  784: != - is discouraged
    line  817: == - is discouraged
    line  819: == - is discouraged
    line  856: == - is discouraged
    line  873: == - is discouraged
    line  897: == - is discouraged
    line  906: != - is discouraged
    line  911: == - is discouraged
    line  918: == - is discouraged
    line  935: == - is discouraged
    line  936: == - is discouraged
    line  940: == - is discouraged
    line  958: == - is discouraged
    line  958: == - is discouraged
    line  960: == - is discouraged
    line  960: == - is discouraged
    line  960: == - is discouraged
    line 1105: != - is discouraged
    line 1188: == - is discouraged
    line 1188: == - is discouraged
    line 1191: == - is discouraged
    line 1191: == - is discouraged
    line 1195: == - is discouraged
    line 1195: == - is discouraged
    line 1247: != - is discouraged
    line 1249: == - is discouraged
    line 1281: == - is discouraged
    line 1337: != - is discouraged
    line 1342: == - is discouraged
    line 1410: == - is discouraged
    line 1422: == - is discouraged
    line 1446: == - is discouraged
    line 1467: == - is discouraged
    line 1477: == - is discouraged
    line 1478: == - is discouraged
    line 1480: == - is discouraged
    line 1482: == - is discouraged
    line 1485: == - is discouraged
    line 1516: == - is discouraged
    line 1544: == - is discouraged
    line 1576: != - is discouraged
    line 1580: == - is discouraged
    line 1708: != - is discouraged
    line 1743: == - is discouraged
    line 1795: != - is discouraged
    line 1821: != - is discouraged
    line 1823: == - is discouraged
    line 1825: == - is discouraged
    line 1841: == - is discouraged
    line 1847: == - is discouraged
    line 1975: == - is discouraged
    line 2016: == - is discouraged
    line 2017: == - is discouraged
    line 2019: == - is discouraged
    line 2021: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Audio/getid3_flac.php
 6 errors
    line   35: != - is discouraged
    line   75: != - is discouraged
    line  161: == - is discouraged
    line  189: == - is discouraged
    line  261: == - is discouraged
    line  371: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/getID3.php
 12 errors
    line   30: != - is discouraged
    line   36: != - is discouraged
    line  290: == - is discouraged
    line  290: == - is discouraged
    line 1048: == - is discouraged
    line 1121: == - is discouraged
    line 1149: == - is discouraged
    line 1196: == - is discouraged
    line 1198: == - is discouraged
    line 1216: == - is discouraged
    line 1218: == - is discouraged
    line 1347: != - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Tags/getid3_id3v2.php
 163 errors
    line   60: == - is discouraged
    line   60: == - is discouraged
    line  159: == - is discouraged
    line  186: == - is discouraged
    line  246: != - is discouraged
    line  263: != - is discouraged
    line  272: == - is discouraged
    line  293: == - is discouraged
    line  303: == - is discouraged
    line  303: == - is discouraged
    line  303: == - is discouraged
    line  303: == - is discouraged
    line  305: == - is discouraged
    line  316: == - is discouraged
    line  316: == - is discouraged
    line  316: == - is discouraged
    line  325: != - is discouraged
    line  372: == - is discouraged
    line  431: == - is discouraged
    line  512: == - is discouraged
    line  563: == - is discouraged
    line  573: == - is discouraged
    line  614: != - is discouraged
    line  619: == - is discouraged
    line  632: == - is discouraged
    line  633: == - is discouraged
    line  633: == - is discouraged
    line  643: == - is discouraged
    line  644: == - is discouraged
    line  644: == - is discouraged
    line  655: == - is discouraged
    line  684: == - is discouraged
    line  693: == - is discouraged
    line  722: == - is discouraged
    line  737: == - is discouraged
    line  738: == - is discouraged
    line  738: == - is discouraged
    line  749: == - is discouraged
    line  788: == - is discouraged
    line  802: == - is discouraged
    line  802: == - is discouraged
    line  803: == - is discouraged
    line  803: == - is discouraged
    line  812: == - is discouraged
    line  825: == - is discouraged
    line  825: == - is discouraged
    line  825: == - is discouraged
    line  844: == - is discouraged
    line  853: == - is discouraged
    line  857: == - is discouraged
    line  882: == - is discouraged
    line  883: == - is discouraged
    line  883: == - is discouraged
    line  893: == - is discouraged
    line  894: == - is discouraged
    line  894: == - is discouraged
    line  919: == - is discouraged
    line  920: == - is discouraged
    line  920: == - is discouraged
    line  952: == - is discouraged
    line  953: == - is discouraged
    line  953: == - is discouraged
    line  967: == - is discouraged
    line  977: == - is discouraged
    line  978: == - is discouraged
    line  978: == - is discouraged
    line  990: == - is discouraged
    line 1019: == - is discouraged
    line 1020: == - is discouraged
    line 1020: == - is discouraged
    line 1038: == - is discouraged
    line 1067: == - is discouraged
    line 1067: != - is discouraged
    line 1079: == - is discouraged
    line 1080: == - is discouraged
    line 1080: == - is discouraged
    line 1098: == - is discouraged
    line 1133: == - is discouraged
    line 1174: == - is discouraged
    line 1174: == - is discouraged
    line 1175: == - is discouraged
    line 1175: == - is discouraged
    line 1217: == - is discouraged
    line 1263: == - is discouraged
    line 1293: == - is discouraged
    line 1293: == - is discouraged
    line 1294: == - is discouraged
    line 1294: == - is discouraged
    line 1324: == - is discouraged
    line 1325: == - is discouraged
    line 1325: == - is discouraged
    line 1355: == - is discouraged
    line 1356: == - is discouraged
    line 1356: == - is discouraged
    line 1371: == - is discouraged
    line 1376: == - is discouraged
    line 1378: == - is discouraged
    line 1387: == - is discouraged
    line 1421: == - is discouraged
    line 1500: == - is discouraged
    line 1501: == - is discouraged
    line 1501: == - is discouraged
    line 1514: == - is discouraged
    line 1556: == - is discouraged
    line 1557: == - is discouraged
    line 1557: == - is discouraged
    line 1567: == - is discouraged
    line 1568: == - is discouraged
    line 1568: == - is discouraged
    line 1590: == - is discouraged
    line 1591: == - is discouraged
    line 1591: == - is discouraged
    line 1608: == - is discouraged
    line 1608: == - is discouraged
    line 1635: == - is discouraged
    line 1636: == - is discouraged
    line 1636: == - is discouraged
    line 1661: == - is discouraged
    line 1662: == - is discouraged
    line 1662: == - is discouraged
    line 1672: == - is discouraged
    line 1695: == - is discouraged
    line 1707: == - is discouraged
    line 1717: == - is discouraged
    line 1734: == - is discouraged
    line 1744: == - is discouraged
    line 1768: == - is discouraged
    line 1785: == - is discouraged
    line 1850: == - is discouraged
    line 1872: == - is discouraged
    line 1895: == - is discouraged
    line 1914: == - is discouraged
    line 1926: == - is discouraged
    line 1935: == - is discouraged
    line 1960: == - is discouraged
    line 2002: == - is discouraged
    line 2019: != - is discouraged
    line 2024: != - is discouraged
    line 2071: == - is discouraged
    line 2071: == - is discouraged
    line 2072: == - is discouraged
    line 2074: == - is discouraged
    line 2098: == - is discouraged
    line 2168: == - is discouraged
    line 2168: == - is discouraged
    line 2169: == - is discouraged
    line 2171: == - is discouraged
    line 3615: == - is discouraged
    line 3617: == - is discouraged
    line 3617: == - is discouraged
    line 3628: != - is discouraged
    line 3637: == - is discouraged
    line 3637: == - is discouraged
    line 3637: == - is discouraged
    line 3646: == - is discouraged
    line 3646: == - is discouraged
    line 3646: == - is discouraged
    line 3646: == - is discouraged
    line 3649: == - is discouraged
    line 3656: == - is discouraged
    line 3734: == - is discouraged
    line 3735: == - is discouraged
    line 3735: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Tags/getid3_lyrics3.php
 12 errors
    line   42: == - is discouraged
    line   49: == - is discouraged
    line   57: == - is discouraged
    line   65: == - is discouraged
    line   81: == - is discouraged
    line   90: == - is discouraged
    line  154: != - is discouraged
    line  176: == - is discouraged
    line  186: == - is discouraged
    line  244: == - is discouraged
    line  295: == - is discouraged
    line  297: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Tags/getid3_id3v1.php
 7 errors
    line   37: == - is discouraged
    line   60: == - is discouraged
    line  110: == - is discouraged
    line  117: == - is discouraged
    line  119: == - is discouraged
    line  339: == - is discouraged
    line  362: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/Tags/getid3_apetag.php
 7 errors
    line   39: == - is discouraged
    line   45: == - is discouraged
    line   51: == - is discouraged
    line   61: == - is discouraged
    line   99: == - is discouraged
    line  204: == - is discouraged
    line  351: != - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/getid3_handler.php
 5 errors
    line  128: == - is discouraged
    line  130: == - is discouraged
    line  148: == - is discouraged
    line  178: != - is discouraged
    line  193: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/getid3_lib.php
 54 errors
    line   71: == - is discouraged
    line  114: == - is discouraged
    line  118: != - is discouraged
    line  118: != - is discouraged
    line  119: == - is discouraged
    line  140: != - is discouraged
    line  217: == - is discouraged
    line  232: == - is discouraged
    line  232: != - is discouraged
    line  235: == - is discouraged
    line  235: == - is discouraged
    line  236: == - is discouraged
    line  241: == - is discouraged
    line  241: == - is discouraged
    line  242: == - is discouraged
    line  248: == - is discouraged
    line  248: != - is discouraged
    line  251: == - is discouraged
    line  254: != - is discouraged
    line  256: == - is discouraged
    line  267: == - is discouraged
    line  320: != - is discouraged
    line  337: == - is discouraged
    line  346: == - is discouraged
    line  566: == - is discouraged
    line  666: == - is discouraged
    line  673: == - is discouraged
    line  679: == - is discouraged
    line  684: == - is discouraged
    line  709: == - is discouraged
    line  716: == - is discouraged
    line  722: == - is discouraged
    line  727: == - is discouraged
    line  752: == - is discouraged
    line  759: == - is discouraged
    line  765: == - is discouraged
    line  770: == - is discouraged
    line  793: == - is discouraged
    line  807: == - is discouraged
    line  821: == - is discouraged
    line  835: == - is discouraged
    line  850: == - is discouraged
    line  852: == - is discouraged
    line  861: == - is discouraged
    line  863: == - is discouraged
    line  871: == - is discouraged
    line  985: == - is discouraged
    line  990: == - is discouraged
    line  994: == - is discouraged
    line 1064: == - is discouraged
    line 1163: == - is discouraged
    line 1168: == - is discouraged
    line 1179: == - is discouraged
    line 1219: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/AudioVideo/getid3_flv.php
 17 errors
    line  100: != - is discouraged
    line  156: == - is discouraged
    line  160: == - is discouraged
    line  168: != - is discouraged
    line  175: == - is discouraged
    line  185: == - is discouraged
    line  244: == - is discouraged
    line  560: == - is discouraged
    line  577: == - is discouraged
    line  577: == - is discouraged
    line  597: == - is discouraged
    line  597: == - is discouraged
    line  657: == - is discouraged
    line  659: == - is discouraged
    line  674: == - is discouraged
    line  722: == - is discouraged
    line  736: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/AudioVideo/getid3_quicktime.php
 39 errors
    line   57: == - is discouraged
    line   70: == - is discouraged
    line  124: == - is discouraged
    line  126: == - is discouraged
    line  128: == - is discouraged
    line  132: == - is discouraged
    line  134: == - is discouraged
    line  136: == - is discouraged
    line  140: == - is discouraged
    line  142: == - is discouraged
    line  144: == - is discouraged
    line  149: == - is discouraged
    line  152: == - is discouraged
    line  155: == - is discouraged
    line  182: == - is discouraged
    line  241: != - is discouraged
    line  393: == - is discouraged
    line  406: == - is discouraged
    line  539: == - is discouraged
    line  863: != - is discouraged
    line 1009: == - is discouraged
    line 1111: == - is discouraged
    line 1111: == - is discouraged
    line 1127: == - is discouraged
    line 1241: == - is discouraged
    line 1286: == - is discouraged
    line 1357: == - is discouraged
    line 1359: == - is discouraged
    line 1377: == - is discouraged
    line 1516: == - is discouraged
    line 1516: == - is discouraged
    line 1593: == - is discouraged
    line 1593: == - is discouraged
    line 1600: == - is discouraged
    line 2177: == - is discouraged
    line 2184: == - is discouraged
    line 2378: != - is discouraged
    line 2384: == - is discouraged
    line 2400: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/AudioVideo/getid3_matroska.php
 21 errors
    line  343: == - is discouraged
    line  343: == - is discouraged
    line  352: != - is discouraged
    line  356: == - is discouraged
    line  356: == - is discouraged
    line  362: == - is discouraged
    line  365: == - is discouraged
    line  454: != - is discouraged
    line  490: == - is discouraged
    line  492: == - is discouraged
    line  544: != - is discouraged
    line  576: != - is discouraged
    line 1210: == - is discouraged
    line 1246: == - is discouraged
    line 1322: == - is discouraged
    line 1396: == - is discouraged
    line 1405: == - is discouraged
    line 1416: != - is discouraged
    line 1418: == - is discouraged
    line 1427: == - is discouraged
    line 1430: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/AudioVideo/getid3_riff.php
 50 errors
    line   82: == - is discouraged
    line   86: != - is discouraged
    line   91: == - is discouraged
    line  103: == - is discouraged
    line  113: == - is discouraged
    line  114: == - is discouraged
    line  151: == - is discouraged
    line  153: == - is discouraged
    line  166: == - is discouraged
    line  199: == - is discouraged
    line  208: == - is discouraged
    line  266: != - is discouraged
    line  266: != - is discouraged
    line  271: != - is discouraged
    line  271: != - is discouraged
    line  394: != - is discouraged
    line  558: == - is discouraged
    line  576: == - is discouraged
    line  588: == - is discouraged
    line  588: == - is discouraged
    line  588: == - is discouraged
    line  602: == - is discouraged
    line  607: == - is discouraged
    line  609: != - is discouraged
    line  671: == - is discouraged
    line  757: == - is discouraged
    line  855: == - is discouraged
    line  858: == - is discouraged
    line  971: == - is discouraged
    line  971: == - is discouraged
    line 1031: == - is discouraged
    line 1294: == - is discouraged
    line 1362: != - is discouraged
    line 1365: != - is discouraged
    line 1387: != - is discouraged
    line 1391: != - is discouraged
    line 1396: != - is discouraged
    line 1400: != - is discouraged
    line 1433: == - is discouraged
    line 1463: == - is discouraged
    line 1463: != - is discouraged
    line 1467: != - is discouraged
    line 1486: == - is discouraged
    line 1587: == - is discouraged
    line 1587: == - is discouraged
    line 1643: == - is discouraged
    line 1674: == - is discouraged
    line 1720: == - is discouraged
    line 1813: != - is discouraged
    line 2592: == - is discouraged
Analysing /var/www/html/apps/metadata/lib/GetID3/AudioVideo/getid3_mpeg.php
 7 errors
    line   79: == - is discouraged
    line  133: == - is discouraged
    line  200: == - is discouraged
    line  208: == - is discouraged
    line  266: == - is discouraged
    line  495: == - is discouraged
    line  513: == - is discouraged
App is not compliant

[gino0631]

Is this causing any practical problems?

[Sanookmakmak]

The web updater failed with "server error" while upgrading from NC13 to 14.
I don't know if the metadata app was responsible but i had it installed.

I could rescue the update process by disabling all apps by hand with the command

occ app:disable appname

For that reason i have checked all installed apps with the command

occ app:check-code appname

and i found out that most of the the apps were "Not compliant"

• Web updater fails when updating from NC13 → 14 if EPUB reader is installed nextcloud/server#11572
• https://help.nextcloud.com/t/nc-14-0-1-bug-list-deprecated-file-found-app-is-not-compliant/38213
• https://help.nextcloud.com/t/update-auf-nc-14-hat-mir-folgendes-problem-bereit/36774

[gino0631]

I'm afraid these complaints about the "==" operator have nothing to do with the problems you have faced during the upgrade. This app is compatible with NC14.

[gino0631]

Closing as this is not a real issue.

[SuperSandro2000]

You are doing not typesafe comparisons all over the place. This could cause a security holes with specially crafted meta data.

[gino0631]

@SuperSandro2000 many things could, not just the comparisons, and these are in GetID3 code BTW, so it's not even realistic to fix.