fix save_unweighted_flag by removing the leading '#' in the first line #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulupo
suggested changes
Apr 26, 2021
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
|
I hope I pressed the right buttons to accept the suggested linting changes :) |
ulupo
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the first line of a saved unweighted flag reads '# dim 0' whereas
flagserstrictly expects 'dim 0'.What does this implement/fix? Explain your changes.
Adding the
comments=''paramenter to np.save fixes this. This is done analogously tosave_weighted_flagAny other comments?
We did not observe this error before as
load_unweighted_flagignores the first line and does not strictly check if it isdim 0.One could "fix" that as well?