appelations to appellations

back/src/adapters/primary/routers/apiKeyAuthRouter/getSearchResultBySiretAndAppellationCodeV2.e2e.test.ts

@@ -140,7 +140,7 @@ describe("Route to get ImmersionSearchResultDto by siret and rome - /v2/offers/:
     expect(response.status).toBe(200);
   });
 
-  it("returns 404 if no offer can be found with such siret & appelation code", async () => {
+  it("returns 404 if no offer can be found with such siret & appellation code", async () => {
     const siretNotInDB = "11000403200019";
 
     const { status, body } =

back/src/domains/convention/adapters/PgConventionQueries.integration.test.ts

@@ -545,7 +545,7 @@ describe("Pg implementation of ConventionQueries", () => {
       const conventionBuilderInitialMatching = new ConventionDtoBuilder()
         .withAgencyId(agency.id)
         .withSiret(matchingSiret)
-        .withImmersionAppelation({
+        .withImmersionAppellation({
           appellationCode: matchingAppellation,
           romeCode: "11111",
           appellationLabel: "osef",
@@ -573,7 +573,7 @@ describe("Pg implementation of ConventionQueries", () => {
 
       const conventionWithWrongAppellation = conventionBuilderInitialMatching
         .withId("33333333-3333-4333-3333-333333333333")
-        .withImmersionAppelation({
+        .withImmersionAppellation({
           appellationCode: "17010",
           romeCode: "11111",
           appellationLabel: "osef",

back/src/domains/convention/use-cases/broadcast/BroadcastToPoleEmploiOnConventionUpdates.unit.test.ts

@@ -192,7 +192,7 @@ describe("Broadcasts events to pole-emploi", () => {
     const convention = new ConventionDtoBuilder()
       .withId(immersionConventionId)
       .withAgencyId(peAgency.id)
-      .withImmersionAppelation({
+      .withImmersionAppellation({
         appellationCode: "11111",
         appellationLabel: "some Appellation",
         romeCode: "A1111",
@@ -263,7 +263,7 @@ describe("Broadcasts events to pole-emploi", () => {
     const convention = new ConventionDtoBuilder()
       .withId(immersionConventionId)
       .withAgencyId(agencyWithRefersTo.id)
-      .withImmersionAppelation({
+      .withImmersionAppellation({
         appellationCode: "11111",
         appellationLabel: "some Appellation",
         romeCode: "A1111",

back/src/domains/core/rome/adapters/InMemoryAppellationsGateway.ts

@@ -10,7 +10,7 @@ export class InMemoryAppellationsGateway implements AppellationsGateway {
     );
   }
 
-  public setNextSearchAppelationsResult(nextResult: AppellationDto[]) {
+  public setNextSearchAppellationsResult(nextResult: AppellationDto[]) {
     this.#nextResults = nextResult;
   }
 

back/src/domains/core/rome/adapters/PgRomeRepository.ts

@@ -41,20 +41,20 @@ export class PgRomeRepository implements RomeRepository {
     codes: AppellationCode[],
   ): Promise<AppellationAndRomeDto[]> {
     return this.transaction
-      .selectFrom("public_appellations_data as appelations")
+      .selectFrom("public_appellations_data as appellations")
       .innerJoin(
         "public_romes_data as romes",
-        "appelations.code_rome",
+        "appellations.code_rome",
         "romes.code_rome",
       )
       .where(
-        "appelations.ogr_appellation",
+        "appellations.ogr_appellation",
         "in",
         codes.map((code) => parseInt(code)),
       )
       .select([
-        "appelations.ogr_appellation",
-        "appelations.libelle_appellation_long",
+        "appellations.ogr_appellation",
+        "appellations.libelle_appellation_long",
         "romes.libelle_rome",
         "romes.code_rome",
       ])

back/src/domains/core/rome/use-cases/AppellationSearch.ts

@@ -49,7 +49,7 @@ export class AppellationSearch extends TransactionalUseCase<
     if (searchText.length < ROME_AND_APPELLATION_MIN_SEARCH_TEXT_LENGTH)
       return [];
     const appellations = fetchAppellationsFromNaturalLanguage
-      ? await this.#naturalLanguageSearchAppelations(uow, searchText)
+      ? await this.#naturalLanguageSearchAppellations(uow, searchText)
       : await uow.romeRepository.searchAppellation(searchText);
 
     const appellationsWithMatch: AppellationMatchDto[] = appellations.map(
@@ -67,15 +67,15 @@ export class AppellationSearch extends TransactionalUseCase<
     return appellationsWithMatch;
   }
 
-  async #naturalLanguageSearchAppelations(
+  async #naturalLanguageSearchAppellations(
     uow: UnitOfWork,
     searchText: string,
   ): Promise<AppellationAndRomeDto[]> {
-    const appelations =
+    const appellations =
       await this.#appellationsGateway.searchAppellations(searchText);
 
     return uow.romeRepository.getAppellationAndRomeDtosFromAppellationCodes(
-      appelations.map(({ appellationCode }) => appellationCode),
+      appellations.map(({ appellationCode }) => appellationCode),
     );
   }
 }

back/src/domains/core/rome/use-cases/AppellationSearch.unit.test.ts

@@ -83,7 +83,7 @@ describe("AppellationSearch", () => {
   });
   describe("with natural language search", () => {
     it("returns the list of found matches with ranges", async () => {
-      appellationsGateway.setNextSearchAppelationsResult([
+      appellationsGateway.setNextSearchAppellationsResult([
         { appellationCode: "19364", appellationLabel: "Secrétaire" },
         {
           appellationCode: "19367",
@@ -136,7 +136,7 @@ describe("AppellationSearch", () => {
     });
 
     it("do not return results if missing on rome repo like ROME 4 results", async () => {
-      appellationsGateway.setNextSearchAppelationsResult([
+      appellationsGateway.setNextSearchAppellationsResult([
         { appellationCode: "19364", appellationLabel: "Secrétaire" },
         {
           appellationCode: "19367",

back/src/domains/establishment/adapters/PgEstablishmentAggregateRepository.integration.test.ts

@@ -1071,7 +1071,7 @@ describe("PgEstablishmentAggregateRepository", () => {
       });
     });
 
-    describe("getOffersAsAppelationDtoForFormEstablishment", () => {
+    describe("getOffersAsAppellationDtoForFormEstablishment", () => {
       beforeEach(async () => {
         await pgEstablishmentAggregateRepository.insertEstablishmentAggregate(
           establishmentWithOfferA1101_AtPosition,
@@ -1138,13 +1138,13 @@ describe("PgEstablishmentAggregateRepository", () => {
         );
       });
 
-      it("undefined when missing offer appelation code", async () => {
-        const missingAppelationCode = artisteCirqueOffer.appellationCode;
+      it("undefined when missing offer appellation code", async () => {
+        const missingAppellationCode = artisteCirqueOffer.appellationCode;
 
         expectToEqual(
           await pgEstablishmentAggregateRepository.getSearchImmersionResultDtoBySearchQuery(
             establishmentWithOfferA1101_AtPosition.establishment.siret,
-            missingAppelationCode,
+            missingAppellationCode,
             establishmentWithOfferA1101_AtPosition.establishment.locations[0]
               .id,
           ),

back/src/domains/establishment/adapters/PgEstablishmentAggregateRepository.ts

@@ -747,19 +747,19 @@ export class PgEstablishmentAggregateRepository
         .where("rome_code", "in", offersToRemoveByRomeCode)
         .execute();
 
-    const offersToRemoveByAppelationCode = offersToRemove
+    const offersToRemoveByAppellationCode = offersToRemove
       .filter((offer) => !!offer.appellationCode)
       .map((offer) => offer.appellationCode);
 
-    if (offersToRemoveByAppelationCode.length > 0)
+    if (offersToRemoveByAppellationCode.length > 0)
       await this.transaction
         .deleteFrom("immersion_offers")
         .where("siret", "=", siret)
         .where(
           "appellation_code",
           "in",
-          offersToRemoveByAppelationCode.map((appelationCode) =>
-            parseInt(appelationCode),
+          offersToRemoveByAppellationCode.map((appellationCode) =>
+            parseInt(appellationCode),
           ),
         )
         .execute();
@@ -958,7 +958,7 @@ const searchImmersionResultsQuery = (
             "loc.id as loc_id",
             "offer.rome_code as code_rome",
             sql`JSON_AGG( JSON_BUILD_OBJECT( 'appellationCode', a.ogr_appellation::text, 'appellationLabel', a.libelle_appellation_long, 'score', offer.score ) ORDER BY a.ogr_appellation)`.as(
-              "appelations",
+              "appellations",
             ),
             sql<number>`ROW_NUMBER() OVER (ORDER BY ${makeOrderByClauses(
               sortedBy,
@@ -1025,7 +1025,7 @@ const searchImmersionResultsQuery = (
               }
             : {}),
           voluntaryToImmersion: sql`TRUE`,
-          appellations: ref("r.appelations"),
+          appellations: ref("r.appellations"),
         }),
       ).as("search_immersion_result"),
     )

back/src/domains/establishment/use-cases/discussions/SendExchangeToRecipient.unit.test.ts

@@ -197,7 +197,7 @@ describe("SendExchangeToRecipient", () => {
       );
     });
 
-    it("throws an error if appelation code does not exist", async () => {
+    it("throws an error if appellation code does not exist", async () => {
       const discussion = new DiscussionBuilder()
         .withAppellationCode("20567")
         .withId(uuid())

shared/src/convention/ConventionDtoBuilder.ts

@@ -522,7 +522,7 @@ export class ConventionDtoBuilder implements Builder<ConventionDto> {
     });
   }
 
-  public withImmersionAppelation(
+  public withImmersionAppellation(
     immersionAppellation: AppellationAndRomeDto,
   ): ConventionDtoBuilder {
     return new ConventionDtoBuilder({

shared/src/discussion/discussion.dto.ts

@@ -171,14 +171,14 @@ export class DiscussionBuilder implements Builder<DiscussionDto> {
   constructor(private readonly discussion: DiscussionDto = defaultDiscussion) {}
 
   public buildRead(
-    appelation: AppellationAndRomeDto = cartographeAppellationAndRome,
+    appellation: AppellationAndRomeDto = cartographeAppellationAndRome,
   ): DiscussionReadDto {
     const { appellationCode, ...rest } = this.discussion;
-    if (appelation.appellationCode !== appellationCode)
-      throw new Error("Appelation code mismatch");
+    if (appellation.appellationCode !== appellationCode)
+      throw new Error("Appellation code mismatch");
     return {
       ...rest,
-      appellation: appelation,
+      appellation: appellation,
       potentialBeneficiary: {
         firstName: this.discussion.potentialBeneficiary.firstName,
         lastName: this.discussion.potentialBeneficiary.lastName,