Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2182 - Wording page admin/agences et page entreprise + TECH : migration pour remplacer agencyOwner par agency-admin et refacto roles en kebab case #2206

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

#2182 - Wording page admin/agences et page entreprise + TECH : migration pour remplacer agencyOwner par agency-admin et refacto roles en kebab case #2206

wants to merge 6 commits into from

Conversation

ClementLmd
Copy link
Contributor

  • wording establishment dashboard page
  • add description to roles in AgencyUserModificationForm
  • wording AgencyDashBoardPage

@ClementLmd ClementLmd self-assigned this Sep 17, 2024
@ClementLmd ClementLmd linked an issue Sep 17, 2024 that may be closed by this pull request
Changements de wordings #2182
Open
@ClementLmd ClementLmd changed the title 2182 changements de wordings #2182 - Modification de wording : page admin/agences et page entreprise Sep 17, 2024
@ClementLmd
Copy link
Contributor Author

ClementLmd commented Sep 17, 2024 •
edited
Loading

Un utilisateur a le rôle d'agencyAdmin (précédemment agencyOwner) en prod, à modifier
==> fait dans un fichier de migration

@ClementLmd ClementLmd marked this pull request as ready for review September 17, 2024 16:03
@github-actions GitHub Actions
Copy link

Review app:
https://if-dev-front-pr2206.osc-fr1.scalingo.io

celineung
celineung reviewed Sep 19, 2024
View reviewed changes
back/src/domains/convention/use-cases/RenewConvention.unit.test.ts Outdated
@@ -273,14 +273,14 @@ describe("RenewConvention", () => {
{
...inclusionConnectedUser,
agencyRights: [
{ agency, roles: ["agencyOwner"], isNotifiedByEmail: false },
{ agency, roles: ["agencyAdmin"], isNotifiedByEmail: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agency-admin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajouter un script de migration pour le renommage du role dans la table users_agencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les rôles ont été passés en kebab case (commit 2724add)
Le script de migration est fait et a été testé en local (commit 0f9c367)

@ClementLmd ClementLmd changed the title #2182 - Modification de wording : page admin/agences et page entreprise #2182 - Wording page admin/agences et page entreprise + migration pour enlever agencyOwner + refacto roles en camel case Sep 19, 2024
@ClementLmd ClementLmd changed the title #2182 - Wording page admin/agences et page entreprise + migration pour enlever agencyOwner + refacto roles en camel case #2182 - Wording page admin/agences et page entreprise + TECH : migration pour remplacer agencyOwner par agency-admin et refacto roles en kebab case Sep 19, 2024
@ClementLmd ClementLmd force-pushed the 2182-changements-de-wordings branch 2 times, most recently from 20fadb0 to fb78a4b Compare September 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celineung celineung celineung approved these changes

Assignees

@ClementLmd ClementLmd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changements de wordings
2 participants
@ClementLmd @celineung