feat(Emails): pouvoir envoyer les e-mails transactionnels depuis TemplateTransactional #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienReuiller
approved these changes
Jan 16, 2024
lemarche/conversations/models.py
Outdated
| @@ -233,3 +234,26 @@ def get_template_id(self): | |||
| elif self.source == conversation_constants.SOURCE_BREVO: | |||
| return self.brevo_id | |||
| return None | |||
|
|
|||
| def send_transactional_email(self, recipient_email, recipient_name, variables): | |||
| print("send_transactional_email", self.source) | |||
There was a problem hiding this comment.
Un petit print qui est resté.
lemarche/conversations/models.py
Outdated
| recipient_email=recipient_email, | ||
| recipient_name=recipient_name, | ||
| variables=variables, | ||
| # from_email=self.email_from_email, |
There was a problem hiding this comment.
Tu ne le fais pas là, mais dans l'idée on pourrait surcharger l'expéditeur ? Brevo et Mailjet le permettent ?
raphodn
force-pushed
the
raphodn/emails-brevo-configuration
branch
from
846d7c4 to
80a4509
Compare
raphodn
force-pushed
the
raphodn/conversation-template-refactor-brevo
branch
from
3b00bba to
75ac069
Compare
raphodn
force-pushed
the
raphodn/conversation-template-refactor-brevo
branch
from
75ac069 to
867e0b0
Compare
raphodn
changed the title
raphodn
changed the title
raphodn
force-pushed
the
raphodn/conversation-template-refactor-brevo
branch
from
21c4a83 to
172a2c6
Compare
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Suite à #1018 on a maintenant un modèle
TemplateTransactionaldans lequel on configure nos envois d'e-mails.En fonction de la config choisie, je rajoute une méthode
send_transactional_email()qui permet d'envoyer directement un e-mail, via Mailjet ou Brevo.subjectest vide par défaut, il utilisera la config en ligne (gros changement ! d'habitude on gérait les subject dans le code)from_email&from_namesont overridablesJ'ai testé avec le template "NEW_USER_PASSWORD_RESET" et ca marche bien 👍
Suite
Dans la prochaine PR - #1019 - on commencera à utiliser ce nouveau mécanisme pour les envois d'e-mails existants. En s'assurant que le subject est bien configuré à la fois dans Mailjet et Brevo.