fix: Autoriser seulement les "GET" sur PerimeterAutocompleteViewSet #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
chloend,
madjid-asa and
SebastienReuiller
Guilouf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
D'après ce bug sur sentry les appels http de type
OPTIONSaboutissent à des erreurs.Pourquoi ?
Contrairement aux autres urls de l'API, cette url ne respecte pas un format correct et limite arbitrairement les résultats sans pagination. Les autres verbes http n'ont pas été prévus quand cette modification a été effectuée, menant à des erreurs.
Comment ?
Seul le verbe
GETest désormais autorisé. L'autre option était de rendre standard cette partie de l'API, mais il aurait fallu changer aussi le code coté client qui consomme cette url.