Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX/UI : Filtrer les fiches salarié de manière plus dynamique #3993

Merged
merged 1 commit into from
May 2, 2024
Merged

UX/UI : Filtrer les fiches salarié de manière plus dynamique #3993

merged 1 commit into from
May 2, 2024

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Apr 29, 2024 •
edited
Loading

🤔 Pourquoi ?

Faciliter la transition vers la nouvelle interface.

🏝️ Comment tester

from tests.employee_record.factories import EmployeeRecordFactory

EmployeeRecordFactory.create_batch(100, job_application__to_company_id=3850)
  1. Se connecter en tant que l’EI Garage Martinet
  2. Depuis le tableau de bord, suivre le lien “Gérer les fiches salarié (ASP)”
  3. Vérifier le fonctionnement des filtres
  4. Vérifier le fonctionnement de la pagination
  5. Vérifier le fonctionnement du tri

@francoisfreitag francoisfreitag self-assigned this Apr 29, 2024
@francoisfreitag francoisfreitag marked this pull request as draft April 29, 2024 16:01
@francoisfreitag francoisfreitag marked this pull request as ready for review April 29, 2024 16:29
@hellodeloo hellodeloo added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Apr 30, 2024
@github-actions GitHub Actions
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

hellodeloo
hellodeloo approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@hellodeloo hellodeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@francoisfreitag francoisfreitag force-pushed the ff/htmx-fs-real branch 2 times, most recently from f48aef5 to a47f689 Compare April 30, 2024 06:59
xavfernandez
xavfernandez approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 🙏

@notion-workspace Notion Workspace
Copy link

🏗️ [Refonte UX/UI] ETQU je veux sélectionner/désélectionner des filtres sans que la page se recharge à chaque fois

@francoisfreitag francoisfreitag force-pushed the ff/htmx-fs-real branch 2 times, most recently from f567750 to 1fac86f Compare May 2, 2024 09:45
@francoisfreitag
Copy link
Contributor Author

francoisfreitag commented May 2, 2024 •
edited
Loading

Je viens d’ajouter un fixup pour un cas qu’on avait raté : la màj des badges de compte de fiches salarié et le select2 des salariés. Si une nouvelle embauche ou une nouvelle FS est ajoutée pendant que l’utilisateur filtre, elle n’apparaitra pas sur la page.
1fac86f

xavfernandez
xavfernandez approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu 👍
Est-ce qu'on souhaite rajouter un test pour ce cas-là ?

@francoisfreitag
Copy link
Contributor Author

francoisfreitag commented May 2, 2024 •
edited
Loading

Bien vu 👍 Est-ce qu'on souhaite rajouter un test pour ce cas-là ?

Bien entendu, c’est pour ça que j’ai ajouté test_htmx_new_employee_record_updates_badge_count dans le même commit ;)

Edit : je me suis foiré, le test a été ajouté avec 58fdc80 🤦

@francoisfreitag
Use HTMX on employee records list
984cf26 
Rewrote the sort button dropdown to use native events and not jQuery
events, so that HTMX can listen to its change events.
@francoisfreitag francoisfreitag enabled auto-merge May 2, 2024 12:55
xavfernandez
xavfernandez approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francoisfreitag francoisfreitag added this pull request to the merge queue May 2, 2024
Merged via the queue into master with commit cc25520 May 2, 2024
10 of 11 checks passed
@francoisfreitag francoisfreitag deleted the ff/htmx-fs-real branch May 2, 2024 13:09
@leo-naeka leo-naeka changed the title UX/UI : Filtrer les fiches salariés de manière plus dynamique UX/UI : Filtrer les fiches salarié de manière plus dynamique Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@hellodeloo hellodeloo hellodeloo approved these changes

Assignees

@francoisfreitag francoisfreitag

Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francoisfreitag @xavfernandez @hellodeloo