Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN-186] Ajout d'un rappel périodique par email pour inviter les administrateurs d'organisations à s'assurer que leurs membres sont bien actifs et autorisés #4015

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[GEN-186] Ajout d'un rappel périodique par email pour inviter les administrateurs d'organisations à s'assurer que leurs membres sont bien actifs et autorisés #4015

merged 1 commit into from
Jul 3, 2024

Conversation

leo-naeka
Copy link
Contributor

@leo-naeka leo-naeka commented May 1, 2024 •
edited
Loading

🤔 Pourquoi ?

Dans le cadre de nos engagements sécurité, nous avons identifié le besoin de sensibiliser les administrateurs à la revue des comptes collaborateurs afin de s’assurer que seules les personnes autorisées ont accès au compte d’une structure ou organisation.

🍰 Comment ?

Nouveau mail envoyé tous les 3 mois aux administrateurs d'organisations (companies, prescriber organization, institution) ayant plus d'un membre.
Programmé tous les 1ers lundis des mois de janvier, avril, juillet, octobre à 9h.

🏝️ Comment tester

En local, lancer la commande de management

🧐 Notes de review (update 11/06)

Suite aux différents échanges :

  • J'ai switch sur une notification (non dismissable)
  • La commande de management traite tout ce qui n'a pas été envoyé depuis plus de 3 mois (et non plus uniquement le jour J tous les 3 mois)
    • Règle le souci de ne pas prévenir pendant tout un trimestre s'il y a un souci un jour particulier (cc Xavier)
    • Peut provoquer un décalage de jours et un pic s'il y a un souci pendant plusieurs jours (cc François)
  • Plus de méthode sur le modèle (notif envoyée directement depuis la commande) → test de la commande et non plus uniquement du mail

@leo-naeka leo-naeka added the ajouté Ajouté dans le changelog. label May 1, 2024
@leo-naeka leo-naeka self-assigned this May 1, 2024
@notion-workspace Notion Workspace
Copy link

✉️ [Engagement Sécurité]email pour inviter les admin à vérifier la liste de leurs collaborateurs tous les 3 mois

@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch from 76c05a5 to 282ea1c Compare May 1, 2024 17:24
rsebille
rsebille reviewed May 22, 2024
View reviewed changes
clevercloud/cron.json Outdated Show resolved Hide resolved
itou/common_apps/organizations/models.py Outdated Show resolved Hide resolved
@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch from 282ea1c to 8ed09ab Compare June 10, 2024 06:57
@leo-naeka leo-naeka marked this pull request as draft June 10, 2024 09:20
@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch 3 times, most recently from 155da80 to 0ddc94f Compare June 11, 2024 14:34
@leo-naeka leo-naeka marked this pull request as ready for review June 11, 2024 14:43
francoisfreitag
francoisfreitag reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message de commit, monthes -> months.

itou/templates/users/emails/check_authorized_members_email_body.txt Outdated Show resolved Hide resolved
itou/templates/users/emails/check_authorized_members_email_body.txt Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
tests/users/test_management_commands.py Outdated Show resolved Hide resolved
tests/users/test_management_commands.py Outdated Show resolved Hide resolved
tests/users/test_management_commands.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Show resolved Hide resolved
tests/users/test_management_commands.py Outdated Show resolved Hide resolved
@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch from 0ddc94f to a9886fd Compare June 26, 2024 06:52
francoisfreitag
francoisfreitag approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu as laissé une note sur le document, mais ne pas oublier https://whimsical.com/notifications-C4VLyZenkkNgW5NFhxC9Py

itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Outdated Show resolved Hide resolved
itou/users/management/commands/send_check_authorized_members_email.py Show resolved Hide resolved
@francoisfreitag
Copy link
Contributor

Top ! :)

@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch 2 times, most recently from 8941072 to 223af45 Compare June 27, 2024 13:24
@leo-naeka leo-naeka force-pushed the leo/periodic-email-check-members branch from 223af45 to 4173d6c Compare July 3, 2024 15:40
@leo-naeka leo-naeka enabled auto-merge July 3, 2024 15:47
@leo-naeka leo-naeka added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 879692a Jul 3, 2024
11 checks passed
@leo-naeka leo-naeka deleted the leo/periodic-email-check-members branch July 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez left review comments

@francoisfreitag francoisfreitag francoisfreitag approved these changes

@rsebille rsebille Awaiting requested review from rsebille

Assignees

@leo-naeka leo-naeka

Labels
ajouté Ajouté dans le changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leo-naeka @francoisfreitag @xavfernandez @rsebille