Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS : liste des groupes > la date n'apparaît pas pour les groupes créés en masse // changement de l'ordre #4279

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

celine-m-s
Copy link
Collaborator

🤔 Pourquoi ?

Demandes remontées pendant l'OL.
J'ai aussi mis à jour les fixtures pour répliquer l'import initial.

💻 Captures d'écran

image

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Se connecter avec l'ETTI (utilisatrice Daphnée Delavigne) puis, en bas du tableau de bord, cliquer sur « Visualiser les bénéficiaires ».

@celine-m-s celine-m-s self-assigned this Jun 21, 2024
@celine-m-s celine-m-s added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Jun 21, 2024
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

Copy link

@celine-m-s celine-m-s added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Jun 21, 2024
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@celine-m-s celine-m-s removed the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Jun 21, 2024
itou/fixtures/django/26_follow_up_groups.json Outdated Show resolved Hide resolved
itou/templates/gps/my_groups.html Outdated Show resolved Hide resolved
tests/gps/__snapshots__/test_views.ambr Outdated Show resolved Hide resolved
- Show groups created lately first.
- Don't display the creation date if membership was created by the
  initial script
itou/templates/gps/my_groups.html Show resolved Hide resolved
FollowUpGroup.objects.follow_beneficiary(beneficiary=beneficiary, user=other_member, is_referent=True)
assert group.memberships.count() == 2
other_membership = group.memberships.get(member=other_member)
assert other_membership.is_referent is True # No limit to the number of referent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On est d'accord que dans ce test il n'y a qu'une seule membership référente & active ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À la fin, oui, car l'autre membership.is_referent est passée à False ligne 52. Mais je suis d'accord avec toi, ce n'est pas évident.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je modifierai ce test une autre fois. Là, j'aimerais bien passer cette PR.

@celine-m-s celine-m-s added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 5000daa Jun 26, 2024
11 checks passed
@celine-m-s celine-m-s deleted the celinems/gps-ui branch June 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants