Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Système permettant de renouveler token d’API RDV-S [GEN-1763] #4356

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

leo-naeka
Copy link
Contributor

@leo-naeka leo-naeka commented Jul 3, 2024

ℹ️ NE PAS RELIRE LE PREMIER COMMIT

🤔 Pourquoi ?

Les API RDV-I et RDV-S partagent la même base d'utilisateurs et les mêmes informations d'identification.

Leurs tokens sont émis pour une durée de 24h et chaque renouvellement invalide les tokens antérieurs.

🍰 Comment ?

Les informations d'identification sont mises en cache et automatiquement actualisées selon le besoin.

@leo-naeka leo-naeka added the ajouté Ajouté dans le changelog. label Jul 3, 2024
@leo-naeka leo-naeka self-assigned this Jul 3, 2024
itou/rdv_insertion/api.py Outdated Show resolved Hide resolved
itou/rdv_insertion/api.py Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Jul 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13074360 Triggered Generic High Entropy Secret 541ccff itou/utils/mocks/rdv_insertion.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@leo-naeka leo-naeka marked this pull request as ready for review July 17, 2024 09:51
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et est-ce qu'on ne souhaiterait pas un petit test ? Je viens de voir qu'il y avait un 3ème commit 😫

itou/rdv_insertion/api.py Outdated Show resolved Hide resolved
config/settings/base.py Outdated Show resolved Hide resolved
itou/rdv_insertion/apps.py Outdated Show resolved Hide resolved
itou/rdv_insertion/api.py Outdated Show resolved Hide resolved
@leo-naeka leo-naeka force-pushed the leo/rdvi-token-renewal branch 3 times, most recently from 9817d1e to dcbd1af Compare July 25, 2024 13:42
@leo-naeka leo-naeka force-pushed the leo/rdvi-token-renewal branch from dcbd1af to 541ccff Compare July 26, 2024 15:45
@leo-naeka leo-naeka added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 1885020 Jul 26, 2024
11 checks passed
@leo-naeka leo-naeka deleted the leo/rdvi-token-renewal branch July 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ajouté Ajouté dans le changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants