GPS : Amélioration des performances de la recherche de bénéficiaires #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
force-pushed
the
ff/gps-2
branch
from
2ee8d06 to
fbc5f4b
Compare
Instead of generating a new column and searching it with `LIKE %term%` (icontains), search a user whose first name or last name is `LIKE term%` (startswith). Also, use a simpler join to exclude beneficiaries for which the user is an active member of their follow up group. Performances ============ Measuring using the SQL panel of DjDT, with the request: ```bash curl 'http://127.0.0.1:8000/autocomplete/gps_users?term=dupont&_type=query&q=dupont' 'Cookie: sessionid=SESSIONID' ``` master: 454 ms commit: 24 ms
francoisfreitag
force-pushed
the
ff/gps-2
branch
from
fbc5f4b to
92421e7
Compare
| search_terms = search_string.split(" ") | ||
| name_q = [] | ||
| for term in search_terms: | ||
| name_q.append(Q(first_name__unaccent__istartswith=term)) |
There was a problem hiding this comment.
On passe de icontains à istartswith... Ça n'est pas la même recherche.
There was a problem hiding this comment.
Je n’ai pas mentionné https://itou-inclusion.slack.com/archives/C067CP07KJR/p1721834260473969 dans la description. On a discuté de ce changement avec Louis-Jean avant que je ne le réalise.
Désolé pour la confusion.
celine-m-s
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
La recherche de bénéficiaire est une nouvelle entrée dans les vues avec le plus haut User Misery sur Sentry (2ème pire vue du système) avec un P50 à plus de 4 secondes, ce qui affecte la base de données et l’expérience sur le site.
Performances
En utilisant le panneau SQL de DjDT, avec la requête :
master: 454 ms
commit: 24 ms
cf https://itou-inclusion.slack.com/archives/C067CP07KJR/p1721834260473969