Employeur : Utilisation d'un drapeau pour rendre une entreprise non recherchable #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itou/www/search/views.py
Outdated
| @@ -75,6 +75,7 @@ def form_valid(self, form): | |||
|
|
|||
| siaes = ( | |||
| Company.objects.active() | |||
| .filter(is_searchable=True) | |||
There was a problem hiding this comment.
Il faudrait aussi rajouter ce filtre sur le queryset job_descriptions juste en dessous non ?
Et passer de :
.exclude(company__block_job_applications=True)
à
.exclude(company__block_job_applications=True, is_searchable=False)
There was a problem hiding this comment.
Oui c'est mieux !
J'inverse au passage la logique ( En fait non :)filter() -> exclude()) pour Company pour avoir la même chose dans les deux queryset et pour coller au défaut qui est qu'on peux rechercher.
rsebille
force-pushed
the
rsebille/companies-searchable-flag
branch
from
10d4a7c to
0a9e112
Compare
xavfernandez
approved these changes
Oct 17, 2024
xavfernandez
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Plus simple à comprendre et utiliser, et ça évite les effets de bord si on souhaite toucher aux coordonnées géographique pour d'autre raison (ce qui est mon cas :D).
Question philosophique du jour : Les
assertSnapshotQueries()font pas mal de bruit à droite et à gauche lors de l'ajout d'un nouveau champ, je me suis donc demander si c'était pas mieux de couper le commit en deux pour séparer l'ajout du champ du reste des changements mais je me dit que ça ne rentre pas dans la logique d'avoir des commits les plus atomiques et donc facilement revertable.