Tableau de bord: correction du message lié au délai de carence pour l'encart PASS IAE du candidat #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user currently has a valid approval do not check for pe approval in waiting period.
xavfernandez
changed the title
leo-naeka
approved these changes
Oct 21, 2024
itou/users/models.py
Outdated
| return (self.latest_approval and not self.latest_approval.is_valid()) or ( | ||
| self.latest_pe_approval and not self.latest_pe_approval.is_valid() | ||
| ) | ||
| def is_latest_common_approval_in_waiting_period(self): |
There was a problem hiding this comment.
nit: j'aurais laissé du has_*
Suggested change
| def is_latest_common_approval_in_waiting_period(self): | |
| def has_latest_common_approval_in_waiting_period(self): |
francoisfreitag
force-pushed
the
xfernandez/fix_has_common_approval_in_waiting_period
branch
from
53afee7 to
7961cab
Compare
To is_latest_common_approval_in_waiting_period which is closer to its behavior.
francoisfreitag
force-pushed
the
xfernandez/fix_has_common_approval_in_waiting_period
branch
from
7961cab to
fcfd644
Compare
francoisfreitag
deleted the
xfernandez/fix_has_common_approval_in_waiting_period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Sinon, même avec un PASS IAE valide, un candidat voyait le message "Un prescripteur habilité a réalisé un diagnostic d'éligibilité. Vous pouvez commencer un nouveau parcours." s'il avait un précédent agrément PE dans le délai de carence.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran