Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nettoyage des modèles d'invitations #5068

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Nov 10, 2024

🤔 Pourquoi ?

Seul le dernier commit est à relire.
Les précédents sont issus de #5067

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the tech label Nov 10, 2024
@tonial tonial self-assigned this Nov 10, 2024
@tonial tonial force-pushed the alaurent/improve_invitations_2 branch 2 times, most recently from afd3aa3 to 97bf62a Compare November 10, 2024 10:40
@tonial tonial changed the title Nettoyage des modèles d'invivations Nettoyage des modèles d'invitations Nov 10, 2024
We don't need "accepted" and "sent" fields when we have a "*_at"
equivalent.
@tonial tonial force-pushed the alaurent/improve_invitations_2 branch from 97bf62a to 1a5cc83 Compare November 12, 2024 15:04
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, je m'étais fait la réflexion en lisant la précédente PR de pourquoi un booléen et une date 😬

@tonial tonial added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit d13cd3f Nov 13, 2024
9 checks passed
@tonial tonial deleted the alaurent/improve_invitations_2 branch November 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants