Permettre l'autoconnection à proconnect sur les liens vers la communauté (DSP) [GEN-2389] #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
added
python
tonial
requested changes
Jan 15, 2025
|
|
||
| @register.simple_tag | ||
| def autologin_proconnect(url, user): | ||
| if user.is_authenticated and user.is_proconnect: |
There was a problem hiding this comment.
Créer cette fonction juste pour ici, ça m'attriste beaucoup.
Suggested change
| if user.is_authenticated and user.is_proconnect: | |
| if user.is_authenticated and user.identity_provider == IdentityProvider.PRO_CONNECT: |
There was a problem hiding this comment.
ça ne mérite pas de tristesse … je l'ai tout de même enlevé ^^
There was a problem hiding this comment.
Je suis d'un naturel sensible 😿
vincentporte
force-pushed
the
vp/autoconnect_on_dsp_create
branch
from
50b8f41 to
4783660
Compare
vincentporte
force-pushed
the
vp/autoconnect_on_dsp_create
branch
from
4783660 to
78811ea
Compare
tonial
approved these changes
Jan 16, 2025
vincentporte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
lien avec l'issue communaute #846
changelog : connexion
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester