Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inscription: Fusionner les vues d'inscription sans type d'utilisateur #5394

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

calummackervoy
Copy link
Contributor

@calummackervoy calummackervoy commented Jan 15, 2025

🤔 Pourquoi ?

La vue créée pour surcharger la vue d'inscription de django-allauth redirige maintenant vers la vue choose_user_kind, afin d'éviter les doublons.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

@calummackervoy calummackervoy added the no-changelog Ne doit pas figurer dans le journal des changements. label Jan 15, 2025
@calummackervoy calummackervoy self-assigned this Jan 15, 2025
@calummackervoy calummackervoy added tech and removed no-changelog Ne doit pas figurer dans le journal des changements. labels Jan 15, 2025
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avec un test en plus c'est top

tests/www/signup/test_allauth.py Show resolved Hide resolved
The endpoint created for overriding django-allauth's signup view now redirects to the choose_user_kind view, to avoid duplicated purpose
@calummackervoy calummackervoy force-pushed the calum/delete-additional-signup-view branch from d160150 to ecebbe1 Compare January 20, 2025 09:25
@calummackervoy calummackervoy added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit 4c54936 Jan 20, 2025
9 checks passed
@calummackervoy calummackervoy deleted the calum/delete-additional-signup-view branch January 20, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants