Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connexion: Fixer le bouton de connexion au compte candidat démonstrative #5440

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

calummackervoy
Copy link
Contributor

🤔 Pourquoi ?

Le action_url pour le connexion des candidats a changé, qui a cassé le templatetag utilisé pendant la connexion à un compte démo.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

  • Connectez-vous avec le compte candidat du démo en local

@calummackervoy calummackervoy added no-changelog Ne doit pas figurer dans le journal des changements. bug labels Jan 21, 2025
@calummackervoy calummackervoy self-assigned this Jan 21, 2025
itou/utils/templatetags/demo_accounts.py Outdated Show resolved Hide resolved
(UserKind.JOB_SEEKER, job_seekers_accounts_tag),
],
)
def test_can_login_to_demo_account(self, client, user_kind, template_tag):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne idée 👍

Copy link
Contributor

@EwenKorr EwenKorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, avec des tests sur tous les types comptes en plus !

@calummackervoy calummackervoy force-pushed the calum/fix-connexion-compte-demo branch from 11c6299 to 869ebbf Compare January 22, 2025 18:34
tests/utils/test_templatetags.py Outdated Show resolved Hide resolved
itou/utils/templatetags/demo_accounts.py Outdated Show resolved Hide resolved
@calummackervoy calummackervoy force-pushed the calum/fix-connexion-compte-demo branch from 869ebbf to babf193 Compare January 23, 2025 10:58
itou/utils/templatetags/demo_accounts.py Outdated Show resolved Hide resolved
The action_url for job-seeker login has changed, causing the JavaScript handling demo account login to break. This commit fixes the action_url and adds a test to that effect
@calummackervoy calummackervoy force-pushed the calum/fix-connexion-compte-demo branch from babf193 to 32177bc Compare January 24, 2025 12:15
@calummackervoy calummackervoy added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit e262d0a Jan 24, 2025
9 checks passed
@calummackervoy calummackervoy deleted the calum/fix-connexion-compte-demo branch January 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants