-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connexion: Fixer le bouton de connexion au compte candidat démonstrative #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calummackervoy
commented
Jan 21, 2025
tests/utils/test_templatetags.py
Outdated
(UserKind.JOB_SEEKER, job_seekers_accounts_tag), | ||
], | ||
) | ||
def test_can_login_to_demo_account(self, client, user_kind, template_tag): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonne idée 👍
EwenKorr
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, avec des tests sur tous les types comptes en plus !
11c6299
to
869ebbf
Compare
869ebbf
to
babf193
Compare
xavfernandez
approved these changes
Jan 23, 2025
The action_url for job-seeker login has changed, causing the JavaScript handling demo account login to break. This commit fixes the action_url and adds a test to that effect
babf193
to
32177bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le
action_url
pour le connexion des candidats a changé, qui a cassé letemplatetag
utilisé pendant la connexion à un compte démo.🚨 À vérifier
🏝️ Comment tester