Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Correction du formulaire des diagnostics d'éligibilité. #5485

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Jan 28, 2025

🤔 Pourquoi ?

Une organisation prescriptrice peut ne plus être habilitée au moment ou l'on modifie le diagnostic pour régulation.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial requested review from leo-naeka and EwenKorr January 28, 2025 08:38
@tonial tonial self-assigned this Jan 28, 2025
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me dis qu'on pourrait toujours rajouter un messages.warning quand on affecte une organisation prescriptrice non habilitée (sans bloquer).

@tonial tonial force-pushed the alaurent/admin_diags branch from d39c05a to 0a8cc76 Compare January 28, 2025 09:17
When fixing past diagnosis, the organization may not be authorized
anymore
@tonial tonial force-pushed the alaurent/admin_diags branch from 0a8cc76 to faaee4d Compare January 28, 2025 09:19
@tonial tonial requested a review from xavfernandez January 28, 2025 09:19
@tonial tonial enabled auto-merge January 28, 2025 09:19
# Allow inactive membership as we may want to fix old diagnoses
self.add_error("author_prescriber_organization", "L'auteur n'appartient pas à cette organisation.")
if author_prescriber_organization and not author_prescriber_organization.is_authorized:
logger.warning("L'organization prescriptrice n'est actuellement pas habilité.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je m'attendais à un messages.warning(request, ...): l'idée c'est que l'utilisateur voit le message 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je crois que les 2 nuits catastrophiques de suite n'aident pas mon cerveau....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 je compatis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et j'ai oublié de bloquer retirer de la merge queue 😭

@tonial tonial added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 76c2a62 Jan 28, 2025
11 checks passed
@tonial tonial deleted the alaurent/admin_diags branch January 28, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants