Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidature: le message de mise en attente par lot est maintenant optionnel #5514

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Candidature: le message de mise en attente par lot est maintenant optionnel #5514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion itou/www/apply/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,6 @@ def __init__(self, hx_post_url, *args, **kwargs):
class BatchPostponeForm(AnswerForm):
def __init__(self, *args, job_seeker_nb, **kwargs):
super().__init__(*args, **kwargs)
self.fields["answer"].required = True
self.fields["answer"].widget.attrs["placeholder"] = (
"Votre réponse sera visible par les candidats et les prescripteurs/orienteurs"
)
Expand Down
4 changes: 2 additions & 2 deletions tests/www/apply/__snapshots__/test_list_for_siae.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,7 @@
<button aria-label="Fermer" class="btn-close" data-bs-dismiss="modal" type="button"></button>
</div>
<form action="/apply/company/batch/postpone?next_url=/apply/siae/list%3Fdisplay%3Dtable%26start_date%3D2015-01-01" method="post">
<div class="modal-body"><div class="form-group form-group-required"><label class="form-label" for="id_answer">Commentaire à envoyer au candidat</label><textarea class="form-control" cols="40" id="id_answer" name="answer" placeholder="Votre réponse sera visible par les candidats et les prescripteurs/orienteurs" required="" rows="10"></textarea></div></div>
<div class="modal-body"><div class="form-group"><label class="form-label" for="id_answer">Commentaire à envoyer au candidat</label><textarea class="form-control" cols="40" id="id_answer" name="answer" placeholder="Votre réponse sera visible par les candidats et les prescripteurs/orienteurs" rows="10"></textarea></div></div>
<div class="modal-footer">
<button class="btn btn-sm btn-outline-secondary" data-bs-dismiss="modal" type="button">Retour</button>
<input name="csrfmiddlewaretoken" type="hidden" value="NORMALIZED_CSRF_TOKEN"/>
Expand Down Expand Up @@ -2580,7 +2580,7 @@
<button aria-label="Fermer" class="btn-close" data-bs-dismiss="modal" type="button"></button>
</div>
<form action="/apply/company/batch/postpone?next_url=/apply/siae/list%3Fdisplay%3Dtable%26start_date%3D2015-01-01" method="post">
<div class="modal-body"><div class="form-group form-group-required"><label class="form-label" for="id_answer">Commentaire à envoyer aux 2 candidats</label><textarea class="form-control" cols="40" id="id_answer" name="answer" placeholder="Votre réponse sera visible par les candidats et les prescripteurs/orienteurs" required="" rows="10"></textarea></div></div>
<div class="modal-body"><div class="form-group"><label class="form-label" for="id_answer">Commentaire à envoyer aux 2 candidats</label><textarea class="form-control" cols="40" id="id_answer" name="answer" placeholder="Votre réponse sera visible par les candidats et les prescripteurs/orienteurs" rows="10"></textarea></div></div>
<div class="modal-footer">
<button class="btn btn-sm btn-outline-secondary" data-bs-dismiss="modal" type="button">Retour</button>
<input name="csrfmiddlewaretoken" type="hidden" value="NORMALIZED_CSRF_TOKEN"/>
Expand Down
10 changes: 3 additions & 7 deletions tests/www/apply/test_batch_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,15 +392,11 @@ def test_missing_answer(self, client):
)
assertRedirects(response, next_url)
postponable_app.refresh_from_db()
assert postponable_app.state != JobApplicationState.POSTPONED
assert not postponable_app.answer
assert postponable_app.state == JobApplicationState.POSTPONED
assert postponable_app.answer == ""
assertMessages(
response,
[
messages.Message(
messages.ERROR, "Les candidatures n’ont pas pu être mises en attente.", extra_tags="toast"
)
],
[messages.Message(messages.SUCCESS, "La candidature a bien été mise en attente.", extra_tags="toast")],
)

def test_unpostponable(self, client):
Expand Down