Simplification du code convergence pour récupérer les sirets convergence directement du c1 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsebille
reviewed
Aug 26, 2024
| s.nom, | ||
| s.type as type_struct, | ||
| s.siret, | ||
| cast(s.siret as bigint) as siret, |
There was a problem hiding this comment.
De ce que je comprend avant c'était fait que dans contrats_aci, ça va pas foutre le bordel dans les tables qui dépendent actuellement de stg_structures et qui s'attendent donc à avoir le siret en string ?
Si pas déjà fait, peut-être tester un dbt run --select "stg_structures+".
There was a problem hiding this comment.
Si si si bien vu ça casse tout.
There was a problem hiding this comment.
J'ai poussé la modif.
laurinehu
force-pushed
the
laurinehu/convergence_structures
branch
from
2017ec8
to
fe82f89
Compare
laurinehu
force-pushed
the
laurinehu/convergence_structures
branch
from
a221f49
to
e1f22b7
Compare
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Carte Notion : **
Pourquoi ?
Nous récupérions jusqu'à maintenant les sirets de convergence à la main dans une seed que nous mettions à jour ponctuellement. Le c1 envoie désormais la liste des structures convergence dans la table structure. Cette PR supprime donc tout ce qui était lié à la màj manuelle des sirets, et fait en sorte de récupérer directement les informations du c1.
Checks