Amélioration et historisation des candidats de la file active #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurinehu
force-pushed
the
laurinehu/candidats_recherche_active
branch
from
8833c1e to
e48a4d3
Compare
laurinehu
requested review from
rsebille and
YannickPassa
and removed request for
rsebille
rsebille
reviewed
Jan 7, 2025
There was a problem hiding this comment.
C"est la clause where de ce fichier qui m'a fait tiquer, mais dans ce modèle faudrait pas remplacer le right join par un inner join vu que candidats_recherche_active.sql regarder stg_candidats_candidatures pour savoir si le candidat est dans la fil active ou pas ça ne devrait rien changer, et peut-être aussi virer la clause where pour ne pas dupliquer la logique des 6 mois à plusieurs endroits ?
| -- the previous state is no longer current if : | ||
| -- 1: dbt_valid_from is bigger than last week date (this line is the new state) // dbt_valid_from is bigger than the last known date | ||
| -- 2: dbt_valid_to is bigger than last week date (this line is the last state that is now finished) // dbt_valid | ||
| where dbt_valid_from >= last_known_date.lkd or dbt_valid_to >= last_known_date.lkd |
There was a problem hiding this comment.
Suggested change
| where dbt_valid_from >= last_known_date.lkd or dbt_valid_to >= last_known_date.lkd | |
| where dbt_valid_from >= last_known_date.lkd or dbt_valid_to >= last_known_date.lkd or dbt_valid_to is null |
Non ? 🤔
| unique_key=['id', 'semaine_valide'], | ||
| post_hook=""" | ||
| DELETE FROM {{ this }} | ||
| WHERE date_derniere_candidature_acceptee is not null and delai_premiere_candidature > 30 |
There was a problem hiding this comment.
J'ai mon cerveau qui fume mais delai_premiere_candidature > 30 c'est pas plus ou moins file_active_30_jours ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Carte Notion : **
Pourquoi ?
Checks