Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fantomas validation to CI #587

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Apr 2, 2024

Description

With this PR, I'm adding fantomas as a dotnet tool and a new CI workflow to use it to check the samples. I'm also updating the EndpointRoutingApp sample to be fantomas compliant.

How to test

Check CI.

Related issues

@64J0 64J0 self-assigned this Apr 2, 2024
@64J0 64J0 marked this pull request as ready for review April 2, 2024 01:18
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you want to eventually move all the code over to it? Might wanna create additional issues or not let this close the current one.

@64J0
Copy link
Member Author

64J0 commented Apr 2, 2024

Nice! Do you want to eventually move all the code over to it? Might wanna create additional issues or not let this close the current one.

This was my original intent when creating that issue. I'll keep it open for more time while deciding what to do. Thanks for the heads-up @TheAngryByrd

@64J0 64J0 merged commit 20e50ce into giraffe-fsharp:develop Apr 2, 2024
6 checks passed
@64J0 64J0 deleted the add-fantomas-ci-samples branch April 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants