Moar fantomas #614
Merged
Moar fantomas #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Sep 5, 2024
|
|
||
| # Always use lf for F# files | ||
| *.fs text eol=lf |
There was a problem hiding this comment.
Life is easier when all files are lf.
Your editor most likely uses LF internally anyway (Rider and code do).
nojaf
commented
Sep 5, 2024
|
|
||
| [*.{fs,fsi,fsx}] | ||
| end_of_line = lf | ||
| fsharp_multiline_bracket_style = aligned |
There was a problem hiding this comment.
Easier for source controle diff.
nojaf
commented
Sep 5, 2024
| [*.{fs,fsi,fsx}] | ||
| end_of_line = lf | ||
| fsharp_multiline_bracket_style = aligned | ||
| fsharp_multi_line_lambda_closing_newline = true |
There was a problem hiding this comment.
Bit of a personal preference.
nojaf
commented
Sep 5, 2024
| fsharp_multi_line_lambda_closing_newline = true | ||
|
|
||
| [{tests,samples}/**/*.fs] | ||
| fsharp_experimental_elmish = true |
There was a problem hiding this comment.
Formats expressions like foo [ bar1 ; bar2 ] nicer.
nojaf
commented
Sep 5, 2024
| @@ -235,25 +235,10 @@ Please be aware that Giraffe strictly aims to remain as light as possible while | |||
|
|
|||
| ### Code conventions | |||
|
|
|||
| When making changes please use existing code as a guideline for coding style and documentation. For example add spaces when creating tuples (`(a,b)` --> `(a, b)`), annotating variable types (`str:string` --> `str : string`) or other language constructs. | |||
| We use [Fantomas](https://fsprojects.github.io/fantomas/docs/index.html) to ensure consistent code formatting across the project. Before committing, format your code by running the following command: | |||
There was a problem hiding this comment.
I did not do any attempt to keep the rules. They were implemented inconsistent anyway and I feel like the default from the style guide suffice here.
TheAngryByrd
approved these changes
Sep 5, 2024
64J0
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Format all F# source code.
How to test
CI should check it, otherwise
dotnet fantomas src tests samples --checkRelated issues
#581