Fix ReadBodyFromRequestAsync disposing ctx.Request.Body
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to test this properly. Ideas are welcome! |
|
The original bug report was that the body gets disposed. I would think that asserting the presence of the body post- |
nojaf
approved these changes
Sep 9, 2024
|
@64J0 Here is a similar type of scenario I had to add over in FsToolkit.ErrorHandling to deal with dispose issues demystifyfp/FsToolkit.ErrorHandling#271 if you were still looking for some unit test ideas |
|
Thanks for the ideas folks! I'll work on it during this week |
…dy is not disposed
…en using ReadBodyFromRequestAsync, and add a new ReadBodyFromRequestAsync function that let's the user define the value of the leaveOpen parameter (useful for tests)
64J0
force-pushed
the
fix-stream-reader-dispose
branch
from
21ded48 to
18152ca
Compare
nojaf
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noticed by @xperiandri, the
ReadBodyFromRequestAsyncseems to be incorrectly disposing thectx.Request.Body. I'm adopting the suggestion from @Banashek, to use theleaveOpen = trueparameter.From the docs:
How to test
Check the automated tests.
*Thanks @Banashek and @1eyewonder for the comments and ideas.
Related issues
useonctx.Request.Body#564