Add new route functions (...WithExtensions) + .NET 8 and 9 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fsharp-analyzers version
fantomas lint samples/RateLimiting remove routeWithExtensions from /no-rate-limit endpoint
64J0
changed the title
64J0
changed the title
| @@ -156,29 +157,71 @@ module Routers = | |||
| | CONNECT -> "CONNECT" | |||
| | _ -> "" | |||
|
|
|||
| [<RequireQualifiedAccess>] | |||
| type AspNetExtension = | |||
There was a problem hiding this comment.
I'm not a fan the DU. This means if someone wants to extend this functionality they have to edit giraffe source code. And if they're doing something custom it's not something we'd want to accept.
It would be better to have a list of IEndpointConventionBuilder -> IEndpointConventionBuilder/unit functions and maybe provide helpers for known ones we'd want to support.
nojaf
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm adding a new alpha endpoint routing functions based on what was presented at PR #619. The new routing functions are:
routeWithExtensionsroutefWithExtensionssubRouteWithExtensionsThere is a new sample showing how to use it with ASP.NET's Rate limiting middleware, a new docs section was added to explain this new feature and more unit tests were added.
As a side-effect of this new feature, the minor .NET version was bumped to 8.0, so some packages were updated accordingly. CI as well.
In the long run my plan is to add new extensions and improve the ones we currently have (this is in alpha as explained by the docs).
How to test
Related issues