Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect highlighting of JSX being a function parameter #120

Closed
unodgs opened this issue Nov 27, 2018 · 7 comments
Closed

Incorrect highlighting of JSX being a function parameter #120

unodgs opened this issue Nov 27, 2018 · 7 comments
Labels
🔥 prio:high parser

Comments

@unodgs
Copy link

unodgs commented Nov 27, 2018

plugin version: 0.68

Description

Recently I discovered bug in the syntax highlighting:
image
If JSX elements are passed as functions parameters they're not highlighted. Take a look at ReactUtils.nvl. Hope it's easy to fix :)
@unodgs unodgs changed the title Incorrect highlighting of JSX being function parameter Incorrect highlighting of JSX being a function parameter Nov 27, 2018
@giraud
Copy link
Owner

giraud commented Dec 4, 2018

do you have published code with the problem?

@unodgs
Copy link
Author

unodgs commented Dec 4, 2018

It's part of commercial product, but I can send you a minimal test case if you wish

@giraud
Copy link
Owner

giraud commented Dec 4, 2018

yep, please

@giraud
Copy link
Owner

giraud commented Dec 15, 2018

@unodgs any news ?

@giraud
Copy link
Owner

giraud commented Dec 17, 2018

I have identified the problem I think

giraud added a commit that referenced this issue Dec 17, 2018
@giraud
#120 - parser improvement
6ce1131
@giraud
Copy link
Owner

giraud commented Dec 17, 2018

v0.69.1

@giraud giraud closed this as completed Dec 17, 2018
@unodgs
Copy link
Author

unodgs commented Jan 18, 2019

Still a problem with my code :) I will try to isolate it (or in the end I will send you a whole file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔥 prio:high parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unodgs @giraud