-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler output listener needs a change for ocaml >= 4.09 #174
Comments
Thanks for the reference. |
should be ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I sent a change to the OCaml compiler to change the format of the error messages ocaml/ocaml#8541. It means that messages printed by OCaml >= 4.09 won't be parsed properly by this LSP server.
The change affects the messages that are on multiple lines. The message now contains the first and last lines. Also the second part of the characters section is no longer a byte offset, it is the position on the last line.
Here is an exemple.
I found two places where a change might be necessary:
https://github.com/reasonml-editor/reasonml-idea-plugin/blob/8a2820d8dedc45f3a93a11a563f8d71fcae2b22d/src/com/reason/build/bs/compiler/BsOutputListener.java#L26
https://github.com/reasonml-editor/reasonml-idea-plugin/blob/8a2820d8dedc45f3a93a11a563f8d71fcae2b22d/src/com/reason/build/dune/DuneOutputListener.java#L28
Tuareg has a list of compilation messages that can be used for reference: https://github.com/Chris00/tuareg/blob/master/compilation.txt
The text was updated successfully, but these errors were encountered: