Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Comment with line comment" action incorrect for lines ending with "(" #319

Closed
jfehrle opened this issue Apr 15, 2021 · 2 comments
Closed

"Comment with line comment" action incorrect for lines ending with "(" #319

jfehrle opened this issue Apr 15, 2021 · 2 comments

Comments

@jfehrle
Copy link
Collaborator

jfehrle commented Apr 15, 2021

plugin version: 0.99-2020.3

For a line ending with "(", the "Comment with line comment" action (CTRL-/) should add " *)" rather than "*)". The latter results in "(*)", which OCaml interprets as the beginning of a nested comment.
giraud added a commit that referenced this issue Mar 21, 2023
@giraud
OCL commenter #319
9e3ed25
giraud added a commit that referenced this issue Mar 21, 2023
@giraud
OCL commenter #319
d017ba3
giraud added a commit that referenced this issue Mar 21, 2023
@giraud
OCL commenter #319
49487e9
giraud added a commit that referenced this issue May 3, 2023
@giraud
OCL commenter #319
2f9ccfa
@giraud
Copy link
Owner

giraud commented May 3, 2023

fixed in 0.111

@giraud giraud closed this as completed May 3, 2023
@jfehrle
Copy link
Collaborator Author

jfehrle commented May 3, 2023

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giraud @jfehrle