Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescript format doesn’t respect UTF-8 encoding #398

Closed
giraud opened this issue Jan 24, 2023 · 1 comment
Closed

Rescript format doesn’t respect UTF-8 encoding #398

giraud opened this issue Jan 24, 2023 · 1 comment

Comments

@giraud
Copy link
Owner

giraud commented Jan 24, 2023 •
edited
Loading

plugin version: 0.109.1

Description

create a rescript file with something like let x = "😩" and format it inside the editor.
result is something like let x = "?".

ResFormatter doesn’t use UTF-8 when saving temporary file
giraud added a commit that referenced this issue Jan 24, 2023
@giraud
use utf-8 when formatting rescript file #398
854306b
giraud added a commit that referenced this issue Jan 24, 2023
@giraud
use utf-8 when formatting rescript file #398
b4a981e
@giraud
Copy link
Owner Author

giraud commented Jan 24, 2023

fixed in 0.109.2

@giraud giraud closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@giraud