Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect ternary parsing in rescript when using newline (rescript) #424

Closed
giraud opened this issue Aug 25, 2023 · 2 comments
Closed

Incorrect ternary parsing in rescript when using newline (rescript) #424

giraud opened this issue Aug 25, 2023 · 2 comments
Assignees
@giraud
Labels
parser

Comments

@giraud
Copy link
Owner

giraud commented Aug 25, 2023

plugin version: 0.115

Description

with this code

let fn = x => x
  ? true
  : false

function body is not parsed correctly
image
@giraud giraud self-assigned this Aug 30, 2023
@giraud giraud added the parser label Aug 30, 2023
@giraud giraud changed the title Incorrect ternary parsing in rescript when using newline Incorrect ternary parsing in rescript when using newline (rescript) Aug 30, 2023
giraud added a commit that referenced this issue Aug 30, 2023
@giraud
Incorrect ternary parsing in rescript when using newline (rescript) #424
c1adcae
@giraud
Copy link
Owner Author

giraud commented Aug 30, 2023 •
edited
Loading

also incorrect parsing:

let fn = x => x
  ? "a"
  : "b" ++ 
    "c"

giraud added a commit that referenced this issue Aug 30, 2023
@giraud
Incorrect ternary parsing in rescript, string_concat (rescript) #424
57068f2
@giraud
Copy link
Owner Author

giraud commented Aug 31, 2023

Fixed in 0.116

@giraud giraud closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giraud giraud

Labels
parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@giraud