Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'"' in comments confuses comment recognition #469

Closed
jfehrle opened this issue Jun 5, 2024 · 2 comments
Closed

'"' in comments confuses comment recognition #469

jfehrle opened this issue Jun 5, 2024 · 2 comments
Assignees
@giraud

Comments

@jfehrle
Copy link
Collaborator

jfehrle commented Jun 5, 2024

plugin version: 0.124-2023.1

Description

The third line should be highlighted as code, not as part of a comment. Looks like the comment recognizer doesn't handle this case.

image

let _ = '"' in
(* '"' *)
let _ = '"' in
(* '"' *)
@giraud giraud self-assigned this Jul 5, 2024
giraud added a commit that referenced this issue Jul 5, 2024
@giraud
'"' in comments confuses comment recognition (#469)
2b78165
giraud added a commit that referenced this issue Jul 5, 2024
@giraud
Remove unused var (#469)
b4fd540
giraud added a commit that referenced this issue Aug 26, 2024
@giraud
'"' in comments confuses comment recognition (#469)
86d51de
giraud added a commit that referenced this issue Aug 26, 2024
@giraud
Remove unused var (#469)
1c3684c
@giraud
Copy link
Owner

giraud commented Aug 26, 2024

Fixed in 0.125

@giraud giraud closed this as completed Aug 26, 2024
@jfehrle
Copy link
Collaborator Author

jfehrle commented Aug 26, 2024

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giraud giraud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giraud @jfehrle