Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color scheme bug in JSX Tag #52

Closed
jsiebern opened this issue May 3, 2018 · 2 comments
Closed

Color scheme bug in JSX Tag #52

jsiebern opened this issue May 3, 2018 · 2 comments
Assignees
@giraud

Comments

@jsiebern
Copy link

jsiebern commented May 3, 2018

plugin version: 0.48.1

Description

Just a small color scheme bug:
2018-05-03_1404
The color in the closing tag differs when using nested modules.

Not important but I still thought it worth reporting :-)
@giraud giraud self-assigned this May 3, 2018
@giraud giraud added the 🐛 bug label May 3, 2018
@giraud giraud removed their assignment May 3, 2018
@jsiebern
Copy link
Author

jsiebern commented May 3, 2018

Similar thing:
2018-05-03_1628

The color for the option tag is probably not intended?

@giraud giraud self-assigned this May 3, 2018
giraud added a commit that referenced this issue May 7, 2018
@giraud
parse option as a JSX tag, not a ReasonML keyword (#52)
0a2d511
giraud added a commit that referenced this issue May 7, 2018
@giraud
parse option as a JSX tag, not a ReasonML keyword (#52)
fc42111
giraud added a commit that referenced this issue May 7, 2018
@giraud
parse tag names with dot (#52)
8b206c9
giraud added a commit that referenced this issue May 7, 2018
@giraud
color option only when it's not a JSX tag (#52)
29d7b5c
@giraud
Copy link
Owner

giraud commented May 17, 2018

Fixed in 0.51

@giraud giraud closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giraud giraud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giraud @jsiebern